On 26/03/15 06:01 PM, Harlan Lieberman-Berg wrote: > Hi Alexandre! Hii :) > I am not with pkg-go -- sorry! But I do have a quick review for you Thanks! > Because there are so many variants of the MIT license, the Debian > copyright-format policy wants the license specified as the more specific > version - Expat is usually compatible with "MIT", but it depends what > the upstream author wants. Done! > The file _example/main.go doesn't comply with gofmt. A quick > run-through of gofmt and sending the patch upstream is an easy fix for > that. I opened a PR upstream and it was merged. I have repackaged, pushed to github, and to mentors.debian.net > Other than that, there's an extra newline in d/copyright. I had done this mistake in all 3 packages. Fixed. > The RFS bug for this package should /probably/ block on the RFS bug for > golang-go-isatty, since this package depends on that one. Not a big > deal, though. Done! > Hope that helps, and thank you for your contributions to Debian! thanks to you :) -- Alexandre Viau alexandre@alexandreviau.net
Attachment:
signature.asc
Description: OpenPGP digital signature