Bug#778729: Try 2: Bug#778729: RFS: git-tools/1.0.0-1 [ITP]
On Sun, Mar 08, 2015 at 04:20:08PM +0100, Stephen Kitt wrote:
> On Tue, 3 Mar 2015 23:52:15 +0100, Adam Borowski <kilobyte@angband.pl> wrote:
> > On Thu, Feb 19, 2015 at 02:53:52AM +0100, Adam Borowski wrote:
> > > * Package name : git-tools
> > > * URL : https://github.com/MestreLion/git-tools
> > >
> > > It builds those binary packages:
> > > git-restore-mtime - set timestamps to the date of a file's last commit
>
> Could you fix up debian/patches/debian-changes? It's just got auto-generated
> template headers... Or is that because you're using single-debian-patch in
> debian/source/options?
The latter. I guess, dpkg-source shouldn't insert that template if
single-debian-patch is set. It's pointless to duplicate the work if all
changes are already tracked and documented in a proper VCS.
> Also, I know this has been debated before, but it seems rather restrictive to
> call the binary package git-restore-mtime, given that there are other useful
> git tools in the package.
Actually, it was the source name that was discussed.
As for binary, my reason is that "git restore-mtime" is the main point of
interest here, the other tools being just thrown in. Their usefulness is
quite marginal. In fact, I dropped two altogether: git-branches-rename and
git-rebase-theirs as both can be reproduced by an one-liner.
As for three tools that I left in, git-find-uncommited-repos probably should
be axed too -- it's just "find -name .git -execdir 'git status'" with some
output massaging. git-strip-merge is both situational and trivial to
reproduce. The only other tool with some real use is git-clone-subset.
Thus, it would feel odd to have a package named "git-tools" that contains
only two tools of some note.
> While I'm at it, given that you're shipping extra manpages, wouldn't it be
> worth it to ship the help2man-generated manpage as well, instead of
> rebuilding it every time?
I build it from source to make sure new upstream changes are incorporated.
On the other hand, this makes it near impossible to adjust the output, and
is inconsistent with the other three manpages, all of which are
hand-crafted. Thus, you're probably right, it would be better to ship
the manpage instead of building it from source.
Meow!
--
// If you believe in so-called "intellectual property", please immediately
// cease using counterfeit alphabets. Instead, contact the nearest temple
// of Amon, whose priests will provide you with scribal services for all
// your writing needs, for Reasonable and Non-Discriminatory prices.
Reply to: