Bug#779377: RFS: classified-ads/0.03-1 / ITP
Tobias Frost writes:
> just re-upload to mentors, and reply to this RFS bug with the changes
> you did (basically quoting my mail and briefly say on every point what
> you did.) I'll pick up from there. Don't file another bug.
Dear Sirs,
I've made some updates to my package, it should available by saying
dget -x http://mentors.debian.net/debian/pool/main/c/classified-ads/classified-ads_0.04-1.dsc
I picked up items from discussion of bug #779377 and tried to address
them somehow, please see following list:
> d/changelog:
> -This file should only contain Debian-related changes. Upstream changes
> -You won't be able to upload to unstable at the moment, since it's
> frozen for jessie. You should change this to "experimental".
=> Cleaned up, target is experimental, added "Closes:" -tag
> d/compat:
> -Debhelper 7 is old. You should switch to 9.
=> Changed
> d/classified-ads.1:
> -You should include this with the software, not just in Debian.
> -You should get rid of the comments explaining what nroff is.
> -You note that "Upon uninstall of the program, the datafile is
> left lingering around". You might want to ask someone else,
> but this seems like bad practice.
=> Moved manpage, removed comments remaining from template and
adjusted the text a bit. Reason for leaving the datafile still
remains but instructions have been added.
> d/control:
> -Priority should be "optional", not "extra".
> -Either fill in the Vcs-* fields, or get rid of them.
> -You've listed some dependencies twice: once in
> d/classified-ads.substvars, and once in d/control.
> -The long description of your package has some spelling/grammatical
> errors and is a bit short. Perhaps you could take some of the
> information off your homepage and put it there?
=> Changed priority, removed Vcs- -field, substvars gone as not needed.
Long description made longer. libqt4-sql-sqlite dependency is not
obvious at compile time so it must remain. For some reason
dpkg-buildpackage does not pick up dep to to libssl so it remains
to be manually listed
> d/copyright:
> -You should use DEP-5 copyright
=> modified format, also changed license GPL3 -> LGPL2.1.
> d/docs:
> -If you don't have any docs, get rid of this file. Otherwise,
> put them in there.
=> Removed
> d/README.source:
> *Delete this file if there is no reason to keep it.
=> Removed
> d/rules:
> -You'll need to update this to dh9 syntax. See here for a guide:
> https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#rules
=> Simplified somewhat.
> General:
> -It's a good idea to keep Debian development and upstream
> development separate. Don't include the debian/ directory
> with your upstream tarballs.
=> In version control debian/ -directory is in different
branch and "gbp buildpackage" seems to correctly exclude that.
(side note, how do I get "gbp buildpackage" to correctly sign
my changes file with GPG or does it sign only git commits or what?)
> -I don't think that Debian can legally distribute classified-ads,
> since Nokia has not made the OpenSSL exception. On the other hand,
> I'm not sure if the LGPL cancels this out. I'm going to ask
> debian-legal.
=> License is now LGPL
> - Another first-sight: icon.png? Somehow does not relate to my
> perceived use of the program
=> Was historical remains, not there any more
> - Why have your source-files have the executeable bit set?
=> Interesting note. Mode has been changed.
> - I'd also know where is the source of the icons? (in images/*)? The
> image in ui Lenin-reading-pravda is probably still under copyright
> protection at least in some countries. This would mean you can not
> distribute it. However, IANAL. (There are also some other png which
> copyright is unclear)
=> now included in copyright and Lenin has been replaced with
Stal^H^H^H^H static text.
> - Why do you need to manually add dependencies to libraries in your
> binary package?
=> Some removed. Sqlite must be manually added as it needed at
runtime only, about openssl I don't know why it is not picked up
automatically..
So, does it look any better now?
--
Antti Järvinen
Reply to: