Bug#778504: RFS: sudoku/1.0.4-1 ITA

[Peter Spiess-Knafl <psk@autistici.org>]

Dear Mentors!

After fixing issues from Jakub Wilks review (thank you very much), I am
again looking for a sponsor for my package sudoku:

 * Package name    : sudoku
   Version         : 1.0.4-1
 * URL             : https://github.com/cinemast/sudoku
 * License         : public-domain
   Section         : games

  It builds those binary packages:

    sudoku     - console based sudoku

  To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/sudoku

  Alternatively, one can download the package with dget using this command:

    dget -x
http://mentors.debian.net/debian/pool/main/s/sudoku/sudoku_1.0.4-1.dsc

Changes since the last upload:

sudoku (1.0.4-1) unstable; urgency=low
  * new upstream release.
  * added desktop and debian-menu files (closes: #738036)
  * debian/control: new maintainer (closes: #774186)
  * debian/control: bump Standards-Version to 3.9.6.
  * debian/control: added VCS-* info.
  * debian/control: added Homepage field.
  * debian/control: Build-Depends on imagemagick for icon generation.
  * debian/docs: added upstream README and CHANGES
  * debian/copyright: changed to machine-readable copyright file.
  * debian/compat: bumped to 9
  * debian/watch: added watchfile and signing key.
  * source format: changed to 3.0 (quilt)

 -- Peter Spiess-Knafl <psk@autistici.org>  Sat, 28 Feb 2015 23:39:43 +0100

Greetings and thank you,
Peter

On 02/25/2015 03:18 PM, Jakub Wilk wrote:
> I don't intend to sponsor this package, but here's my review:
> 
> * Peter Spiess-Knafl <psk@autistici.org>, 2015-02-16, 00:17:
>> http://mentors.debian.net/debian/pool/main/s/sudoku/sudoku_1.0.3-1.dsc
> 
> This is new upstream release, which is the most important change; yet
> this change is not documented in the changelog.
> 
> Other changes that are missing from debian/changelog:
> - new stuff in Build-Depends;
> - Homepage field;
> - debian/docs;
> - source format;
> - debian/watch and upstream signing key.
> 
> If you added sudoku.png and sudoku.xpm to debian/clean, you wouldn't
> need the dh_auto_clean override.
> 
> I'm curious about this part of the code:
> 
>> static const unsigned char default_template [] = {
>> T2(d,h,x,l,9,i,e,w,1,m,i,0,u,9,1,c,2,u,l,9,b,h,x,
>> d,1,y,e,1,q,8,w,e,e,c,h,x,3,2,b,7,z,1,3,p,0,x),
>> T2(r,0,x,n,e,c,9,u,e,n,4,8,t,n,2,i,l,w,3,n,b,1,y,
>> r,e,w,0,h,p,3,u,7,8,c,g,w,8,8,i,e,z,g,1,b,2,y),
>> T2(r,e,y,3,3,5,7,t,2,n,4,h,t,n,e,4,8,s,f,f,q,2,y,
>> 6,g,v,3,g,b,3,t,h,9,5,0,s,m,g,5,f,x,g,e,j,h,s),
> ...
> 
> Was it generated somehow, or did upstream type it all by hand?
> 
> Typos:
> 
> curseslibrary -> curses library
> wil vork -> will work
> meaasge -> message
> Beeep -> Beep
> dependendence -> dependence
> soleyly -> solely
> overwite -> overwrite
> higliht -> highlight
> no mre -> no more
> sreen -> seen
> occured -> occurred
> independend -> independent
> whan no formatsare -> when no formats are
> Reenable -> Re-enable
> 
> 
>> More information about hello can be obtained from http://www.example.com.
> 
> Are you sure about this part? :-P
>