Bug#777500: RFS: birdie/1.1-1 [ITP]

[Tobias Frost <tobi@debian.org>]

Control: Tags -1 moreinfo
Control: Tags -1 owner !

Hi Kay,

Thanks for contributing to Debian

I see that this is your first package in Debian so,
http://mentors.debian.net/intro-maintainers might be a suggested
reading. (note that the above is a standard text I write always to new
sponsorees)
 

So lets start with birdie, here is a review.

- please always check the results on the mentors page:
http://mentors.debian.net/package/birdie tells you already that there
are some issues which should be fixed: UNRELEASED, no homepage, no
watchfile. Please check also all the "I" and "P" type warnings of
lintian and look if you can do something against them

- You need take ownership of the your ITP.

Into the package
- do not override "missing manpages lintian warnings" -- write them (the
man pages)
- please run "wrap-and-sort" on your debian directory -- it makes some
files easier to read.

- d/control: 
 * do not have a "." at the end of the short description, also the first
letter should not be capitalized. -- ref to  6.2.2 in the developers
reference. 
* are all those versions in your B-D's really required? (If the version
in Jessie is already newer than your requirement then drop it -- and
you're still nice to backporters)
* There is no homepage field.

- d/copyright:
 * it is not usual use the copyright-symbol ©, a Copyright: <year>
<name> is sufficient©  
 * The copyright is actually "Copyright: 2013-2014 Birdie Developers"
as stated in the source files, and upstream uses a odd (but valid)
license grant if which you should include a verbatim copy:
" This software is licensed under the GNU General Public License
  (version 3 or later). See the COPYING file in this distribution.
  .
  You should have received a copy of the GNU Library General Public
  License along with this software; if not, write to the
  Free Software Foundation, Inc., 59 Temple Place - Suite 330,
  Boston, MA 02111-1307, USA.
 .
 On Debian systems, the full text of the GNU General Public License
 version 3 can be found in the file `/usr/share/common-licenses/GPL-3'."

* the files in the dir cmake are not documented.

- the patch should have a proper dep3-style header. (and the bug
mentioned in your patch has nothing in common with it)
- why is this patch needed? why are you creating the file in the name of
the upstream authors?

- did not try: are the icons regnerated at build time? There is also an
oddity: icons/128x128/apps has the svg in it, also other dirs have the
svg 

Other:
 - There is no VCS-* field it is really really recommended to have
packaging in a vcs repositry those days, e.g in git (and using
git-buildpackage. )  Please not this is no requirement from Policy or
like; I just do not sponsor packages not in a VCS.) 

So there's some homework... Ping me again when ready or feel free to ask
if you need more details. Then I will complete the review -- (it's quite
late already)

Again, Thanks for contributing!
--
tobi