Bug#774120: RFS: libjson-rpc-cpp/0.4.1-2 [ITP]
* Peter Spiess-Knafl <psk@autistici.org>, 2014-12-29, 03:22:
http://mentors.debian.net/package/libjson-rpc-cpp
... which points us to:
http://mentors.debian.net/debian/pool/main/libj/libjson-rpc-cpp/libjson-rpc-cpp_0.4.2-1.dsc
I don't intend to sponsor this package, but here's my quick review:
Typos in the package descriptions:
Stubgenerator -> Stub generator
sub classed -> subclassed
according -> corresponding
Short descriptions are not full sentences, so they don't need to start
with capital letters.
There's an empty line (escaped by dot) at the end of libjsonrpccpp-dev
description. This is odd...
OTOH you probably want to add empty line between paragraphs in
libjsonrpccpp-tools description. Otherwise tools showing the description
are allowed to wrap them into a single line.
The MIT license in debian/copyright have similar problems with missing
newlines between paragraphs and spurious trailing newline.
The short license name should be Expat, not MIT.
Why do you use a more restrictive license for debian/ than for the rest
of the code?
Typo in debian/changelog:
Overrided -> Overrode
(Although my preference is to have only a single changelog entry for the
initial upload.)
You might want to export the upstream signing key with
"--export-options=export-minimal". This should greatly reduce the
exported key size.
In doc/manpage.in, in the OPTIONS section, all "-" should be replaced
"\-".
What is the purpose of this line src/examples/index.html?
<meta content="utf-8" http-equiv="encoding">
--
Jakub Wilk
Reply to: