[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#773861: Signify - OpenBSD's cryptographic signing tool



Thanks for the review

>> http://mentors.debian.net/debian/pool/main/s/signify-openbsd/signify-openbsd_8-1.dsc
>>
> 
> The package FTBFS here:
> |    dh_auto_clean
> | make[1]: Entering directory
> '/build/signify-openbsd-EGTooy/signify-openbsd-8'
> | /bin/sh: 1: pkg-config: not found
> | Makefile:52: *** libbsd is not installed or version is older than
> 0.7.  Stop.
> | make[1]: Leaving directory
> '/build/signify-openbsd-EGTooy/signify-openbsd-8'
> | dh_auto_clean: make -j1 distclean returned exit code 2
> | make: *** [clean] Error 2

I've added pkg-config as a Build-Depends, and tested the package using
cowbuilder. This error is no longer be present.

> Renaming files using patches (move-manpage.patch) is a bad idea. Rename
> it in debian/rules instead.

Done.

> Have you talked with upstream about the name collision?

No, I haven't. OpenBSD is definitely not going to change the name,
although the maintainer of the portable version might.

Before I ask the maintainer of the portable version to do so, I'd like
to see what the maintainer of Debian's signify thinks about this. If he
would be willing to rename /usr/bin/signify and
/usr/share/man/man1/signify.1.gz to something else, signify-openbsd
would be easier to maintain, and more consistent with upstream.

There hasn't been an upload of the signify package since 2004, so it
should be easier to keep up with upstream changes (if there are any more).

I've CC'd this message to the signify maintainer for input.

> Typos in upstream code:
> equivilent -> equivalent
> ouput -> output

Do these really have to be fixed? They won't be visible to the user, and
it's likely to annoy upstream more than anything. I'll do it if I have
to, though.


Reply to: