Hi Eric, On Fri, Oct 17, 2014 at 5:01 PM, Eric Shattow <lucent@gmail.com> wrote: > On Sat, 11 Oct 2014 17:33:58 -0700 Vincent Cheng <vcheng@debian.org> wrote: >> I'm not sure how I missed this in my earlier review, but note that >> CC-BY-SA version 2.5 is *not* DFSG-compatible; only version 3.0 and >> later are considered DFSG-free by ftpmasters [1][2]. As such, files >> licensed under CC-BY-SA 2.5 must be removed from the source tarball >> (or re-licensed upstream). >> >> Regards, >> Vincent >> >> [1] https://wiki.debian.org/DFSGLicenses >> [2] https://lists.debian.org/debian-project/2013/01/msg00082.html > > The CC-BY-SA-2.5 licensed file is now removed in upstream git. For > existing release 2.22 I've affected this removal by > debian/copyright::Files-Excluded, debian/watch, and a quilt patch. > > See: dget -x http://mentors.debian.net/debian/pool/main/a/audiotools/audiotools_2.22+dfsg1-1.dsc First off, sorry for the delay! Your package looks fine to me; the only (small) issue I could find is that you should be closing the ITP bug report in d/changelog, not your RFS bug. However, it seems to FTBFS (full build log attached; here's the relevant part): /usr/bin/make -C docs make[2]: Entering directory '/tmp/buildd/audiotools-2.22+dfsg1/docs' cd reference && make audioformats-letter.pdf make[3]: Entering directory '/tmp/buildd/audiotools-2.22+dfsg1/docs/reference' python simple-template.py -D PAPERSIZE=letterpaper audioformats.template > audioformats-letter.tex ./bitdiagram.py -i figures/diagram.bdx -o figures/diagram.pdf *** ReportLab is required Please fetch the open-source version from http://www.reportlab.org Makefile:828: recipe for target 'figures/diagram.pdf' failed make[3]: *** [figures/diagram.pdf] Error 1 Perhaps you're missing a build-dep (python-reportlab)? Regards, Vincent
Attachment:
audiotools_2.22+dfsg1-1_amd64.build
Description: Binary data