Bug#773378: RFS: ledgersmb/1.3.46-1
Control: tag -1 moreinfo
Hi Robert,
On Wed, Dec 17, 2014 at 8:54 AM, Robert James Clay <jame@rocasa.us> wrote:
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "ledgersmb"
>
> * Package name : ledgersmb
> Version : 1.3.46-1
> Upstream Author : Chris Travers <chris@metatrontech.com>
> * URL : http://www.ledgersmb.org
> * License : GPL-2+
> Section : web
>
> It builds those binary packages:
>
> ledgersmb - financial accounting and ERP program
>
> To access further information about this package, please visit the following
> URL:
>
> http://mentors.debian.net/package/ledgersmb
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x
> http://mentors.debian.net/debian/pool/main/l/ledgersmb/ledgersmb_1.3.46-1.dsc
>
> More information about ledgersmb can be obtained from
> http://www.ledgersmb.org.
>
> Changes since the last upload:
>
> * New upstream release. (Closes: #771822)
> - Fixes 'Duplicate message' errors in locale/po/hu.po. (Closes: #752063)
> * Add texlive-xetex as a 'Suggests' in debian/control.
> * Add new Dutch debconf translation. (Closes: #767242)
> * Minor updates and corrections to debian/README.Debian.
> * Add libjs-prototype & libjs-scriptaculous to Build-Depends.
> * Correct a copyright email address in the debian/copyright file.
> * Set permissions on ledgersmb/bin/gl.pl correctly in debian/rules.
> * Add a note regarding texlive-xetex to the debian/README.Debian file.
> * Set Standards-Version to 3.9.6 in debian/control, no changes required.
> * The contrib_dir setting in 05_confdir.patch is only needed for Pg v9.1.
> * Remove the use of drop_statoverride function from the maintainer scripts.
> * Use dh-linktree for embedded libjs-prototype and libjs-libjs-scriptaculous
> libraries.
> * Only include the overrides for the 'custom' empty directories in the
> ledgersmb.lintian-overrides.
Just a few small questions/comments from skimming through the debdiff:
- You added a small dpkg-maintscript-helper snippet to
debian/ledgersmb.postrm, specifically checking if dpkg is new enough
to support mv_conffile before using it; what happens if dpkg isn't
sufficiently new enough to support that / is that something that
should just fail? You can simply add a Pre-Depends:
${misc:Pre-Depends} (which will add a pre-dependency on the
appropriate version of dpkg) if you want to use
dpkg-maintscript-helper and not have to worry about whether dpkg is
new enough (and avoid that "if dpkg-maintscript-helper supports
mv_conffile" logic).
- Why bump the version number in debian/NEWS when there isn't a new
entry, and nothing else in the file has changed aside from the
timestamp? That seems likely to just annoy apt-listchanges users.
Also, note that since Debian is in freeze right now, if you wish to
target unstable, any (RC) bugfix uploads that you wish to get into
jessie would then have to go through testing-proposed-updates (which
the release team apparently really doesn't like). Are you sure you're
ok with that?
Regards,
Vincent
Reply to: