Hi Davy, nice to hear from you again.. Sorry, its already late today, so I won't complete review now... I need some clarifcation regarding the images in resources/: Where are those images from? Please dokument every image with its license. What me worries: At least csv.png seems non-DFSG-free (license Creative Commons Attribution-NoDerivs 3.0; http://www.iconsdb.com/black-icons/csv-icon.html; http://icons8.com/license/). d/copyright misses at least a Files: * rule and you need to update the years on debian/* Please check every file. E.g. one says: 2014, Davy Triponney <davy.triponney@gmail.com> 2014, Andrea Celani <acelani74@gmail.com> but there is no Andrea Celani in d/copyright! Thanks! Please understand as the licenses of the images are show-stoppers, I will wait for your response before looking to the rest. Am Mittwoch, den 22.10.2014, 18:58 +0200 schrieb Davy Triponney: > Dear Tobi, dear maintainers, > > > I uploaded another version of Polyphone (1.5). > > > Sources have been modified so that the following libraries are not > included anymore: > > - qcustomplot, > > - stk, > > - rtmidi. > > > Regarding the sfArk parser, I fulfilled in using only one library > instead of two to read sfArk files. However Qt variables are still > used (qint16, quint16, ...) and one small class heavily rely on Qt > libraries (QMap, QFile, QByteArray...). So I didn't fill an ITP bug > for this parser. > > Copyrights should be ok. > > > Regarding my application to be a maintainer... I have other projects > in mind and won't have time for this unfortunately. But I can of > course continue to evolve my package to fix bugs or discrepancies with > Debian QA. > > > Regards, > Davy >
Attachment:
signature.asc
Description: This is a digitally signed message part