[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#758163: Subject: RFS: kcm-ufw/0.4.3-1 ITP



Hi Shawn,

You need do some adjustments in your package. Please:

1. d/changelog: rewrite this file, refering to the last version only.
You can see an example here[1].

[1] https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#changelog

2. d/control:
     - Your Vcs-* points to a empty repository.
     - The Vcs-Git has an invalid address.
     - In long description, change the last semicolon (in list) by a dot.

3. d/copyright:
     - You need inspect each file to find the individual authors and
licenses. You can use ->  egrep -sriA25 '(copyright|public domain)' *
<- to do it.
     - I saw several files licensed as GPL-2+.
     - You can see an example here[2].

[2] http://metadata.ftp-master.debian.org/changelogs/main/e/ext4magic/unstable_copyright

4. d/lintian-overrides: the correct comment must be about the symlink
refers to a package dependency.

5. d/patches/fix_about_dialogue.diff: do you sent this patch to
upstream? You can fix the upstream years too...

6. Do you have a Lintian message: kcm-ufw:
copyright-refers-to-symlink-license usr/share/common-licenses/GFDL.

7. Please, remove all excessive blank lines from end of files. Use
'tail -n1 *' to see these lines.

Cheers,

Eriberto


Reply to: