Bug#762464: RFS: fyba/4.1.1-1 [ITP]

[Ruben Undheim <ruben.undheim@gmail.com>]

Hi,

I'm attaching this thread to the bug report for future reference.

Thanks to both you.

I'm still a bit puzzled about the shlibs/symbols issue, though.


>>> 1. d/control:
>>>   - Change DH level from 9.0.0 to 9.
>>
>> I must have done this by mistake on auto-pilot! I've changed it to 9.0.0 now.
>
>
> No, no... 9!  :-)

Ooops, the worst thing is that I did not do it on purpose this time
either! There must be some kind of automatic spelling correction
haunting me. :)

Regards,
Ruben

2014-09-26 1:29 GMT+02:00 Eriberto <eriberto@eriberto.pro.br>:
> 2014-09-25 17:40 GMT-03:00 Ruben Undheim <ruben.undheim@gmail.com>:
>> Hi Eriberto,
>
>
> Hi Ruben!
>
>
>> Thank you very much for spending your valuable time and reviewing
>> yet another package!
>
>
> I am glad to help you.
>
>
>>> 1. d/control:
>>>   - Change DH level from 9.0.0 to 9.
>>
>> I must have done this by mistake on auto-pilot! I've changed it to 9.0.0 now.
>
>
> No, no... 9!  :-)
>
>
>>> 2. You have Lintian messages:
>>>
>>> I: libfyba0: no-symbols-control-file usr/lib/x86_64-linux-gnu/libfygm.so.0.0.0
>>> I: libfyba0: no-symbols-control-file usr/lib/x86_64-linux-gnu/libfyut.so.0.0.0
>>> I: libfyba0: no-symbols-control-file usr/lib/x86_64-linux-gnu/libfyba.so.0.0.0
>>>
>>> After the debuild command you need generate symbols[1] using this
>>> command in upstream place:
>>>
>>> dpkg-gensymbols -v4.1.1 -plibfyba0 -Odebian/libfyba0.symbols
>>>
>>> [1] https://www.debian.org/doc/debian-policy/ch-sharedlibs.html#s-providing-symbols
>>
>> Actually I did generate a symbol file first, but when I tried to build it on
>> another computer, I got into trouble, and then I found something online
>> that for C++ libraries (which FYBA is), shlibs files are recommended
>> instead and I
>> added an shlibs file instead - and then removed the symbols file.
>
>
> There is something wrong because we have a valid Lintian message.
>
>
>>> 3. The blhc command show some issues:
>>>
>>> blhc --all fyba_4.1.1-1_amd64.build
>>>
>>> To fix it, in d/rules, change from
>>>
>>> export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
>>>
>>> to
>>>
>>> export DEB_BUILD_MAINT_OPTIONS = hardening=+all
>>
>> Hardening seems to have been applied correctly afterwards:
>>
>> ruben@debianmaskin:~/devel/deb_fyba@ hardening-check
>> /usr/lib/x86_64-linux-gnu/libfyba.so.0.0.0
>> /usr/lib/x86_64-linux-gnu/libfyba.so.0.0.0:
>>  Position Independent Executable: no, regular shared library (ignored)
>>  Stack protected: yes
>>  Fortify Source functions: yes (some protected functions found)
>>  Read-only relocations: yes
>>  Immediate binding: no, not found!
>>
>> and I believe this is because debhelper version 9 does this automatically
>> as long as CPPFLAGS, CFLAGS and LDFLAGS are passed down correctly.
>> Let me know if I've misunderstood.
>
>
> DH9 passes the basic flags only.
>
>
>> It seems like Steffen Möller already uploaded the package, so probably
>> you don't have to
>> do so much more this time!
>
>
> It was strange for me but I think that was a little mistake. No problem.
>
>
>> At least I managed to do it with much less
>> issues this time than
>> with gnuais! (the last package you sponsored for me)
>
>
> Good! You will improve your skill package by package. Congratulations!
>
>
>> I really appreciate that you gave the package some attention.
>
>
> You are welcome. Thanks for your work.
>
> Cheers,
>
> Eriberto