[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#745135: Top 10 reasons you should sponsor MariaDB 10.0 into Debian this weekend (Re: Bug#745135: RFS: mariadb-10.0/10.0.13-1 [ITP] -- Latest version of worlds most popular non-Oracle database)



On Tue, Sep 23, 2014 at 2:28 AM, Guido van Steen
<vansteen@users.sourceforge.net> wrote:
> Dear Otto,
>
> I would like Mariadb to be accepted before the freeze as well. However
> I am not a DD, so I cannot sponsor it myself.
>
> In order to get Mariadb sponsored you might handle at least the
> Lintian error (https://lintian.debian.org/tags/build-depends-on-obsolete-package.html,
> http://labs.seravo.fi/~otto/mariadb-repo/logs/mariadb-10.0/mariadb-10.0_10.0.13-1_amd64.build-d992d30.log).
> If it is a false positive, please explain why.
>
> Yesterday Arnoud Fontaine expressed his willingness to sponsor
> (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745135#69). He asks
> "What's blocking the upload to unstable?". Other sponsors may have the
> same question.
>

I haven't performed a full review of the package, but there were a
couple things I noticed with the lintian overrides.

> O command-with-path-in-maintainer-script

> postinst:196 /bin/echo (override comment: ash's buildin has no "-e" so use /bin/echo)
> postinst:210 /bin/echo (override comment: ash's buildin has no "-e" so use /bin/echo)
> postinst:218 /bin/echo (override comment: ash's buildin has no "-e" so use /bin/echo)

The POSIX way to accomplish this is not to use echo at all, use printf.

> O executable-not-elf-or-script

> usr/share/mysql/mysql-test/suite/parts/r/partition_exch_innodb.result (override comment: OK, this file is part of test suite and only used for a test)
> usr/share/mysql/mysql-test/suite/parts/r/partition_exch_qa.result (override comment: OK, this file is part of test suite and only used for a test)

It's fine that these are for the test suite, but do they need to be executable?

> O arch-dependent-file-not-in-arch-specific-directory

> usr/lib/mysql/plugin/dialog.so (override comment: OK, file names don't conflict with the MySQL version)
> usr/lib/mysql/plugin/mysql_clear_password.so (override comment: OK, file names don't conflict with the MySQL version)

I am not sure I understand this override. The issue here is that
libmariadbclient18:amd64 and libmariadbclient18:i386 will not be
co-installable.


Regards,
Jordan Metzmeier


Reply to: