[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#757966: RFS: lutris/0.3.4-1 [ITP]

Thanks for your help. I have updated the package on mentors.

1. Done.

2.
	- Done.
	- Done.
	- Done.
	- My work is now on GitHub: https://github.com/Rudloff/lutris-debian
GitHub uses the same URL for browser and git clone, you should I still fill both fields? - You can manually add to your Lutris library any game that can be installed on your computer (either natively or with Wine). Do you think the description can be misleading? 
	- Are you talking about game platforms? I've added a list of those.
	
3.
	- I am not sure I understand. It does use the 1.0 format.
- Where should I list the upstream authors? I don't see a field for this in the 1.0 format.
4. For some reason, help2man adds this statement at the end of every man page it generates. I removed it. I have also documented the different ways to install a game.
5. Lintian was complaining that the package did not include any upstream changelog so I added one from the upstream debian directory (oddly, I only contained information about the software itself and not the packaging). Anyway, I removed it. 

6. I have added a generic README.source about quilt. Is this OK?

Please tell me if I did anything wrong. Thanks.

Regards,

Le 16/09/2014 15:59, Eriberto a écrit :

Hi Pierre,

Thanks for your fast reply. I will try help you.

1. d/changelog: please, use 'Initial release' instead of 'source
package automatically created by stdeb 0.6.0+git'.

2. d/control:
      - Change the Priority from extra to optional[1].
      - The upstream INSTALL file says that you must use Python 2.7.
So, change from 'python (<< 2.8), python (>= 2.7)' to 'python' in
Build-Depends and remove from Depends. The X-Python-Version field is
used to notify the system about the correct version to be used.
      - The same problem with X-Python-Version. Use 'X-Python-Version:
2.7'. More details here[2].
      - Please, create a VCS to control your debian/ versions. You can
use github or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to
d/control. You can see an example here[3].
      - In short description, is right the afirmation 'any video game'?
Is it real?
      - In long description, remove extra spaces in last three lines. I
saw in upstream site (GitHub) a list about some games that can be used
with lutris. To improve your long description and allow more people to
find your package via apt-cache search, I suggest add a list of
possible games.

[1] https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#control
[2] https://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html#s-specifying_versions
[3] http://sources.debian.net/src/yowsup/0.0~git20140314.938cf1-1/debian/control/

3. d/copyright: you should use the 1.0 format. Please, read this short
document[4] and fix this file.

[4] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

Other comment is that you must to list all upstream authors and
licenses in d/copyright.

4. d/lutris.6: I asked: "Where I can find the 'info' manual of the
game?", because your manpage says: "The full documentation for lutris
is maintained as a Texinfo manual.  If the info and lutris programs
are properly installed at your site, the command 'info lutris' should
give you access to the complete manual."

I would appreciate it if you put an example of installation of the
game in manpage (the complete line command).

5. d/rules:
     - Please, remove all comments.
     - Why you are installing a changelog from Ubuntu (made by
upstream)? Please, remove it and the file ChangeLog.

6. Add a d/README.source file saying about the changes need in
upstream tarball to generate the package.

Thanks for your work. I will wait your package.

Cheers,

Eriberto


2014-09-15 19:52 GMT-03:00 Pierre Rudloff <contact@rudloff.pro>:

Hello,

Sorry, I thought it was better to reuse an existing package.
I have rebuilt it from scratch: http://mentors.debian.net/package/lutris

Here are the answers to your questions:
1. It does not use it anymore.
2. I have set it to 9, which seems to be the current level.
3. It isn't a game but a game manager, so isn't a man page enough?
4. It has one now.
5. I think it should be in main, as it complies with the DFSG and does not
rely on non-free packages.

Regards,


Le 15/09/2014 22:22, Eriberto a écrit :


Hi Pierre,

I checked your package and you are using/cloning the original upstream
packaging.

To put a package in Debian you must remove the debian/ directory from
upstream source code and generate a new tarball. So, you must start a
new Debian package. You can use some ideas from upstream, not clone
the code only.

I would like you to answer some questions:

1. Why the package is using CDBS?

2. What is the current DH level?

3. Where I can find the 'info' manual of the game?

4. Why the package hasn't a X-Python-Version field?

5. Your package must be main, contrib or non-free? Why?

If your want to put a package in Debian, you must have sufficient
skill to maintain this package and solve bugs etc. I suggest you look
at 'Debian New Maintainers' Guide'[1] and, after this, review your
package. If you have doubts, you can ask for help in Debian Mentors
List[2].

I wish a good work for you.

Cheers,

Eriberto

[1] https://www.debian.org/doc/manuals/maint-guide/
[2] https://lists.debian.org/debian-mentors/


2014-08-12 17:04 GMT-03:00 Pierre Rudloff <contact@rudloff.pro>:




Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "lutris"

     * Package name    : lutris
       Version         : 0.3.4-1
       Upstream Author : Mathieu Comandon <strycore@gmail.com>
     * URL             : https://lutris.net/
     * License         : GPLv3
       Section         : games

It builds those binary packages:

      lutris     - Install and play any video game easily

To access further information about this package, please visit the
following
URL:

http://mentors.debian.net/package/lutris


Alternatively, one can download the package with dget using this
command:

      dget -x

http://mentors.debian.net/debian/pool/main/l/lutris/lutris_0.3.4-1.dsc

More information about lutris can be obtained from
https://lutris.net/.

Changes since the last upload:
     * Rebuild for unstable
     * Closes: #754129


Regards,
     Pierre Rudloff




--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact
listmaster@lists.debian.org
Archive: [🔎] 54176DB1.7000201@rudloff.pro">https://lists.debian.org/[🔎] 54176DB1.7000201@rudloff.pro
Reply to: