Bug#747169: RFS: socksjs-twisted/1.2.1-1 [ITP]
> I will try help you with this package.
Thanks a LOT.
> 1. d/control:
>
> - Sorry, but your long description is strange. My impression is
> that you tried to transform a paragraph in a list, without basic
> modifications. Please, can you adjust it? Use semicolons instead
> commas in the list at end of line.
I enhanced the long description a bit.
> - Please, create a VCS to control your debian/ versions. You can
> use github or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to
> d/control. You can see an example here[1].
Done.
> 2. d/copyright:
>
> - Use the verbatim license from upstream code (LICENSE file). As
> an example, the upstream says "Neither the name of the Christopher
> Gamble nor the names of its", while the d/copyright says "Neither the
> name of Oracle nor the names of its".
Fixed.
> - I found this:
>
> qunit/html/static/qunit.css: * Copyright (c) 2011 John Resig, Jörn Zaefferer
> qunit/html/static/qunit.css- * Dual licensed under the MIT (MIT-LICENSE.txt)
> qunit/html/static/qunit.css- * or GPL (GPL-LICENSE.txt) licenses.
>
> Please, check each file and its licenses. I suggest 'grep -sriA25
> copyright *' to help you.
I fixed it and other stuff.
> - I suggest (you can drop it) that you put the license texts as
> end of file. You can see an example here[2]. It will make easier to
> visualize the files.
>
> [2] http://metadata.ftp-master.debian.org/changelogs/main/e/ext4magic/unstable_copyright
Done.
> 3. What makes your patch? My impression is that you are "injecting" a
> third-part code in upstream. Is this? If yes, you mus add it as an
> dependency of the package. If not packaged, you need package it.
The patch adds the missing source for minified js files. See
https://lintian.debian.org/tags/source-is-missing.html
> 4. d/watch: githubredir is deprecated and GitHub accepts scan. Please,
> read this[3].
Done.
> 5. When building, we have a message:
>
> dpkg-gencontrol: warning: Breaks field of package
> python-twisted-sockjs: unknown substitution variable ${python:Breaks}
Fixed.
> 6. Do you see these lintian messages?
>
> P: sockjs-twisted source: source-contains-prebuilt-javascript-object
> qunit/html/static/jquery.min.js
> P: sockjs-twisted source: source-contains-prebuilt-javascript-object
> qunit/html/static/qunit.min.js
Those are fixed by the patch and are false positives, see above and a
lintian bug :
https://bugs.debian.org/744972
My changes are available at https://github.com/niol/sockjs-twisted and
an updated package has been uploaded to mentors.
Alex
Reply to: