Bug#761074: RFS: cputool/0.0.7-1 [ITP]

[Nigel Kukard <nkukard@lbsd.net>]

Hi there Tobias,

I'd just like to thank you again for the time you've taken below and 
pointing me in the right direction, its very much appreciated.

Nothing but perfection is really not good enough ;), I've made a note on 
each item and will include it in my own checks in future.

On 09/11/2014 06:31 AM, Tobias Frost wrote:
> > >    - there are extra ",s" after the years in line 8 and 12
> > Could you clarify this for me Tobias, I must be missing something, I
> > copied an example that Eriberto gave me here...
> >
> > http://metadata.ftp-master.debian.org/changelogs/main/s/sentinella/unstable_copyright
> The format is specified in
> https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#copyright-field
> The file format gives you many freedoms, so you format actually not
> really wrong, but for the symmetry the "," was somehow disturbing my
> eyes as a comma indicates somehow "there is something to follow". As
> said, its a nitpick.

Excellent!  I see what you mean, its the ,'s behind the dates.

I've removed them, it does look a bit easier on the eyes.

Thanks for pointing this out!

> > > -> d/control
> > >    - I'd prefer only to override when necessary. In this case, please
> > > remove the file using d/clean.
> > >    - please use dh_autoreconf
> > Sorted. I now have this, I hope its what you were referring to...
> > ***
> > $ cat rules
> > #!/usr/bin/make -f
> >
> > %:
> >       dh $@ --with autoreconf
> >
> > ***
> Yes, perfect. (you've also added a B-D on dh_autoreconf, haven't you?)

Excellent, thanks Tobias.

I've made the relevant changes, I hope you find them satisfactory and 
feel free to note any other improvements I can make to improve quality :)

http://mentors.debian.net/package/cputool
dget -x 
http://mentors.debian.net/debian/pool/main/c/cputool/cputool_0.0.7-1.dsc

-N