Hallo Tobias, thanks a lot for reviewing my package! On Mon, Sep 01, 2014 at 10:04:32PM +0200, Tobias Frost wrote: > -> Package does not build, misses at least a B-D on libusb-1.0-0-dev > and pkg-config I fixed the build-deps and now it builds using sbuild. > -> as the manpage is created using help2man, you should regenerate it > during build The upstream package now uses help2man. > -> you do not need to set a link from the debian manpage, but you can > directly install the manpage. (See 5.16 of the new maintainers' guide) Fixed > -> You should dh_autoreconf instead of autotools-dev (as you also use > automake), see https://wiki.debian.org/Autoreconf#Using_autotools-dev > -> d/changelog Debian version starts at "-1" for new packages, and state > only "Initial Release (Closes #ITP-Bug)" Done > -> please use spaces for indentation in d/copyright > -> same for postinst > -> don't install README -- is has no additional information and only > duplicates the package description > -> you need to depend on adduser in your binary pacakge. Done > (The review might be incomplete as I have to stop now; please fix the > above and re-upload to mentors, then give me a ping You can now find the package at http://mentors.debian.net/debian/pool/main/a/air-quality-sensor/air-quality-sensor_0.1.2-1.dsc Kind Regards, Benedikt Wildenhain
Attachment:
signature.asc
Description: Digital signature