Bug#741648: RFS: cbootimage/1.2-2
Hi Marc,
2014-08-25 10:47 GMT-03:00 Marc Dietrich <marvin24@gmx.de>:
>>
>> 1. d/control:
>> - Change debhelper from 9.0.0 to 9.
You didn't it.
>> - Create a VCS to control your /debian versions. You can use
>> github or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to
>> d/control.
>
> mmh, dpkg-buildpackage seems not to understand Vcs-* tags (Ubuntu 14.04).
> I added them anyways.
I think you didn't undertand my words. You must create a VCS to
control your packaging (debian directory). Not create a VCS to point
to upstream code. The Vcs-Git field must use git:// instead https://.
Your mistake was put the Vcs-* in binaries instead in source block
(after Homepage field).
>> 2. d/copyright: update the packaging copyright years from 2013 to
>> 2013-2014 and upstream copyright years to 2012-2013.
>
> ok.
Your packaging years are wrong. You already have the cbootimage 1.0-1
in Debian and it was uploaded in 2013. You renamed the d/copyright to
d/cbootimage.copyright. This procedure is inadequate.
>> 3. Do you saw that already there the 1.4 version?
>
> yes, I already created a 1.3 version. Nevertheless, I updated to 1.4 now.
Ok.
>> 4. Some lintan messages[2] that you need to fix:
>>
>> cbootimage: description-possibly-contains-homepage
>> http://http.download.nvidia.com/tegra-public-appnotes/bct-overview.html.
>>
>> W: cbootimage: binary-without-manpage usr/bin/bct_dump
>> W: cbootimage: binary-without-manpage usr/bin/cbootimage
>
> In v1.3 I added man (self written) pages. I still want to convert them using
> a more common tool (from xml to man). Maybe later.
>
> I also added the config files for cbootimage, which normally live in a
> seperate repository. I didn't want to create another source package for these,
> because basicly, they belong together (you cannot use cbootimage without a
> config, but you can run it).
Sorry but not acceptable. You can't 'inject' code in original upstream
code. Debian will distribute this source code as original. So, you
must keep it original.
> Feel free to re-check the result.
You have several Lintian messages:
I: cbootimage source: quilt-patch-missing-description add-man-pages.diff
W: cbootimage source: no-debian-copyright
P: cbootimage source: debian-watch-may-check-gpg-signature
P: cbootimage-configs: no-upstream-changelog
E: cbootimage-configs: copyright-should-refer-to-common-license-file-for-gpl
I: cbootimage-configs: extended-description-is-probably-too-short
W: cbootimage-configs: package-contains-vcs-control-file
usr/share/cbootimage/configs/.gitignore
W: cbootimage-configs: executable-not-elf-or-script
usr/share/cbootimage/configs/tegra124/nvidia/jetson-tk1/PM375_Hynix_2GB_H5TC4G63AFR_RDA_924MHz.bct.cfg
W: cbootimage-configs: executable-not-elf-or-script
usr/share/cbootimage/configs/tegra30/toradex/colibri_t30/colibri_t30_12MHz_1GB_NT5CC256M16CP-DI_400MHz-shmoo.bct.cfg
P: cbootimage: no-upstream-changelog
Your package needs more attention if you really want to upload it to
Debian. Please, read the 'Debian New Maintainers Guide'[1] to you
understand how a Debian package works.
Regards,
Eriberto
Reply to: