Bug#739889: RFS: twython/3.1.2-1 [ITP] -- Pure Python wrapper for the Twitter API

On Thu, Aug 7, 2014 at 5:58 AM, Eriberto <eriberto@eriberto.pro.br> wrote:

Sorry, but three last changes:

1. Remove requirements.txt from d/docs. This information is specific
to packager, not to final user.

2. In d/rules, remove the useless lines '# -*- makefile -*-' and '#
Uncomment this to turn on verbose mode.'

3. I studied the upstream repository and he doesn't declares a
version. You can see that after several changes in repository, after
your packaging, in 'setup.py' we can see 3.1.2 yet. So, use as version
the Git information: 0.0 to version, the date and Git commit (or other
similar format). An example: 0.0~git20140314.938cf1. In your case,
considering that you will update the upstream code:
0.0~git20140805.54647c. To see more examples: $ dpkg -l | grep -i git.

When you do it, I will upload your package. No more changes.

Thanks!

Eriberto

2014-08-07 3:58 GMT-03:00 Josué Ortega <josueortega@debian.org.gt>:

>
>
>
> On Tue, Aug 5, 2014 at 2:44 PM, Eriberto <eriberto@eriberto.pro.br> wrote:
>>
>> Hi!
>>
>> No need rename. And is dh_installchangelogs, not dh_autoinstalldocs.
>>
>> Cheers,
>>
>> Eriberto
>>
>>
>> 2014-08-05 17:37 GMT-03:00 Josué Ortega <josueortega@debian.org.gt>:
>> >
>> > I have one question about dh_autoinstalldocs, should I rename the
>> > History.rst before
>> > pass it as parementer to dh_autoinstalldocs?
>
>
>
> Hi Eriberto,
>
> I have made the changes you asked for.
> The new version is on mentors [0][1]. Thanks.
>
> Cheers,
>
> [0]:
> http://mentors.debian.net/debian/pool/main/t/twython/twython_3.1.2-1.dsc
> [1]: http://mentors.debian.net/package/twython
>
> --
> Josue Ortega
> Happy Hacking
> http://josueortega.org
> PGP key 4096R/AB4AFD3F 2012-08-20
> Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
>

Hi Eriberto

Thanks for your time, I've made the changes you requested, but I've found the following problems:

I've packaged the latest upstream version taking the latest commit as you told me but I've noticed

the tarball on PyPi[0] does not include the docs directory.

This directory includes some minified _javascript_ scripts[1][2] and this directory is present in the

tarball downloaded from Github.

I thought that repacking the tarball would be the solution, since the repack script uses uscan and the

watch file is searching in PyPi and the Github URL doesn't manage any version just the branch name [3],

as far as I understand repacking using the repack script will not fix the problem.

What approach do you think is the best?

I suggest working with the pypi releases which don't include the minified js files.

Cheers

[0]: https://pypi.python.org/pypi/twython

[1]: https://github.com/ryanmcgrath/twython/blob/master/docs/_themes/basicstrap/static/js/jquery.min.js

[2]: https://github.com/ryanmcgrath/twython/blob/master/docs/_themes/basicstrap/static/js/bootstrap.min.js

[3]: https://github.com/ryanmcgrath/twython/archive/master.tar.gz

Josue Ortega

Happy Hacking
http://josueortega.org

PGP key 4096R/AB4AFD3F 2012-08-20

Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F