Hola Eriberto,
sorry for my late answer. Yesterday I have a lot of trouble at work.
Thanks you for your review.
Am Mittwoch, den 06.08.2014, 20:24 -0300 schrieb Eriberto:
> tags 746392 moreinfo
> thanks
>
>
>
> Hi Jörg,
>
> I found several problems in this little package. Please:
>
fccp was one of my first debian packages. And after I hear thats very
difficult to find a sponsor for ITPs I don't spend more time in it.
Therefore a you have found a lot of mistakes :-( .
> 1. d/control: you didn't use a Vcs and the long description is poor. I
> already packaged some softwares suggested by программист некто
> <programmer11180@programist.ru>. Commonly, he writes good
> descriptions. In this case, see the RFP bug (#745898).
>
I have got the description from the upstream maintainer.
Change to the version from the bug.
The Vcs is now on alioth:
http://anonscm.debian.org/cgit/collab-maint/fast-cpp-csv-parser.git
> 2. d/copyright: is a good idea use the same license from upstream to
> debian/. It can avoid a possible conflict between licenses.
I prefer GPL for my work. In this package I don't see an conflict
between GPL and BSD. If there is a conflict in the future, I have no
problem to change the license.
>
> 3. The dh_install already create directories. So, if you have a target
> directory in d/install, you needn't create it via d/dirs.
Removed.
>
> 4. d/docs: you can't distribute a PDF file without a source code. So,
> please, add a source code or remove the PDF and d/doc-base.
The documentation as html and pdf file is now in d/docs.
>
> 5. d/README.Debian: I think that the information is useless.
>
Removed
> 6. d/README.source: "und" (German?). From time to time I also make
> this type of mistake, but in Brazilian Portuguese. :-P
;-) corrected
>
> 7. d/rules: remove the useless comments and keep commented the verbose line.
>
Done. I've also added the section get-orig-source.
> 8. d/source.lintian-overrides: remove it. Create a d/watch and put an
> explanation about the situation. Or let the Lintian speak. I prefer a
> d/watch.
Override removed. And a useless d/watch only for the lintian? I think
then it is better to have a lintian info about that.
> Good night!
>
From your 2. mail:
> A bit more...
>
> 1. d/copyright: the 'Source:' field (download site) should be
> https://code.google.com/p/fast-cpp-csv-parser/source/browse/csv.h
Changed
>
>
> 2. While I was driving from work to my house, I thought ... Where you
> found the upstream version as being -3? I only found commits from Git
> in upstream repository. So, you must use 0.0, the date and Git commit
> as version (or other similar format). An example:
> 0.0~git20140314.938cf1. In your case: 0.0~git20140429.0a2590. To see
> more examples: $ dpkg -l | grep -i git.
I get the -3 from here:
https://code.google.com/p/fast-cpp-csv-parser/downloads/detail?name=csv_v3.h&can=1&q=
But this is marked as deprecated. I have change the version to
0.0+git20140808~0a259084edad-1
>
>
> 3. If you add an extra documentation (as a PDF and its source), you
> should put it in debian/ and add a note in README.source.
The docu is now in d/doc.
> Cheers,
>
> Eriberto
CU
Jörg
--
pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8 EBCB 422B 44B0 BE58 1B6E
pgp Key: BE581B6E
CAcert Key S/N: 0E:D4:56
Jörg Frings-Fürst
D-54526 Niederkail
Threema: SYR8SJXB
IRC: j_f-f@freenode.net
j_f-f@oftc.net
Attachment:
signature.asc
Description: This is a digitally signed message part