Bug#728220: RFS: fatcat/1.0.4-1 [ITP]

[Eriberto <eriberto@eriberto.pro.br>]

I am test your program. I suggest these changes in you code (optional for you):


--- fatcat-1.0.5.orig/man/fatcat.1      2014-08-07 18:34:36.000000000 -0300
+++ fatcat-1.0.5/man/fatcat.1   2014-08-08 07:47:07.185209964 -0300
@@ -11,7 +11,7 @@
 ..

 .\" Contact g.passault@gmail.com to correct errors or typos.
-.TH man 8 "29 October 2013" "1.0" "fatcat man page"
+.TH man 1 "07 August 2014" "1.0.5" "fatcat man page"
 .SH NAME
 fatcat \- FAT filesystem explore, extract, repair, and forensic tool
 .SH SYNOPSIS
diff -Naur fatcat-1.0.5.orig/src/fatcat.cpp fatcat-1.0.5/src/fatcat.cpp
--- fatcat-1.0.5.orig/src/fatcat.cpp    2014-08-07 18:34:36.000000000 -0300
+++ fatcat-1.0.5/src/fatcat.cpp 2014-08-08 07:44:58.849205858 -0300
@@ -20,9 +20,9 @@

 void usage()
 {
-    cout << "fatcat v1.0, Gregwar <g.passault@gmail.com>" << endl;
+    cout << "fatcat v1.0.5, Gregwar <g.passault@gmail.com>" << endl;
     cout << endl;
-    cout << "Usage: fatcat disk.img [options]" << endl;
+    cout << "Usage: fatcat [options] disk.img" << endl;
     cout << "  -i: display information about disk" << endl;
     cout << "  -O [offset]: global offset (may be partition place)" << endl;
     cout << endl;


Note that the manpage level MUST be changed from 8 to 1, as showed above.

Thanks,

Eriberto



2014-08-08 7:40 GMT-03:00 Eriberto <eriberto@eriberto.pro.br>:
> No problems. But your d/copyright is wrong now. Change to:
>
> Files: *
> Copyright: 2013-2014 Grégoire Passault <g.passault@gmail.com>
> License: MIT
>
> I was going upload your package. But, considering you need to change
> the d/copyright and that I had a problem in my system that generated
> false positives (sorry for this again), you can safely remove these
> lines from d/rules:
>
> export DEB_BUILD_MAINT_OPTIONS = hardening=+all
> DPKG_EXPORT_BUILDFLAGS = 1
> include /usr/share/dpkg/buildflags.mk
>
> Send me your final package and I will upload it.
>
> Cheers,
>
> Eriberto
>
>
> 2014-08-07 18:35 GMT-03:00 Grégoire Passault <g.passault@gmail.com>:
>> Actually, I've updated it to 1.0.5, which adds some features
>> Is it a problem?