Control: owner -1 !
Hey bofh80,
* bofh80 <afm404@gmail.com> [2014-07-14 16:27:40 +0100]:
> Thanks for the feedback, I've uploaded 0.6.1 with an extra depends.
> I've checked in a vm without e17 installed this time to make sure it works
> first.
> If you'd be so kind as to check the new version and let me know?
>
> http://mentors.debian.net/package/terminology
>
> The respective dsc file can be found at:
> http://mentors.debian.net/debian/pool/main/t/terminology/terminology_0.6.1-1.dsc
>
> Sorry for the delay in getting back to you, I missed it, came before i
> subscribed to the mailing list.
Terminology has piqued my interest for a while now, and I want to see it in
Debian so I'll sponsor you.
Here's my review:
- debian/README.source is useless.
- debian/copyright:
- you're not Sebastian Reichel, are you? :)
- ltmain.sh is GPL-2
- the copyright for src/bin/lz4 is missing
- the copyright years need updating, and I think the authors list is outdated.
- the *_eet.* seem to be autogenerated. ftpmasters will probably want them
to be built from source, although not having source is fine wrt the license
(BSD2). I don't see the source anywhere.
- debian/control:
- The descriptions need more work: the list of features needs trimming,
and/or reformatting.
- You might want to Suggest: libelementary-bin and let people know how to
switch to OpenGL rendering in a README.Debian. Soft rendering is toasty.
- debian/rules:
- you should trim the comments/debmake foo and keep it simple.
- DPKG_EXPORT_BUILDFLAGS = 1 is the default in debhelper compat level 9
- please have debhelper pass --disable-silent-rules to configure.
- I think the exports (from the upstream README) are useful at runtime.
- debian/terminology.lintian-overrides: I'm not a big fan of overriding the
binary-without-manpage lintian warning, but I won't make you write the
manpages either (I like writing manpages, but I understand not everyone does).
I'd leave the warning as a reminder that those extra executables need some
documentation.
- debian/changelog: I'd merge the two entries in a single one, as the first
one never entered Debian.
- debian/watch: it seems that upstream switched to bz2 tarballs. See
https://wiki.debian.org/debian/watch#Common_mistakes for a hint.
Furthermore the 0.6.1 version doesn't exist there. You should either update
it or provide a get-orig-source target in d/rules to rebuild the tarball you
used.
Build is ok, lintian seems happy. Things seem to run fine too.
Setting aside the sourceless files bit, those issues shouldn't be very hard to
fix. Please talk to upstream about the autogenerated files, we really want to
ship the source, and ideally, we need the machinery to regenerate them at build
time.
Cheers,
--
Nicolas Dandrimont
BOFH excuse #191:
Just type 'mv * /dev/null'.
Attachment:
signature.asc
Description: Digital signature