Bug#754962: RFS: tiptop/2.2 [ITP] -- performance monitoring for Linux via hardware counters

[Vincent Legout <vincent@legout.info>]

Hi Tomasz,

Tomasz Buchert <tomasz.buchert@inria.fr> writes:

> I am looking for a sponsor for my package "tiptop":

I'm interested in sponsoring tiptop, I just have some comments:

The package doesn't provide the tiptoprc file from upstream. I think it
would make sense to install it somewhere even if it is not used, maybe
in /usr/share/doc/tiptop.

It seems the git repository and the dsc on mentors differ. I think the
git version is correct, you only need to close #754932. The descriptions
are also different.

According to the source files in src/, the copyright is 2011-2014
Inria. Thus I believe you should also add Inria in debian/copyright.

In debian/copyright, tiptop is GPL-2 but you used the text for GPL-2+
(i.e. with or (at your option) any later version). You also have 2
identical paragraphs for the debian/ directory.

I can't build the package twice in a row. Not sure why, but maybe
because these files are not deleted by dh clean: Makefile, config.h,
config.log, config.status and src/Makefile. I didn't investigate too
much but it also seems that running debclean twice in a row fails
because ./configure is removed by dh_autoreconf_clean and is needed in
Makefile.

I think there is a typo in the manpage: s/if forked/is forked/

Could you please fix this and I'll be happy to upload tiptop.

Thanks,
Vincent