Bug#752897: RFS: lucene++/3.0.6-1 [ITP]
Hi Łukasz,
(Please note, I just can review, but I can't sponsor you.)
d/control:
- XSBC-Original-Maintainer is ubuntu specific, please remove.
- The versioned dependency on doxygen is not needed as oldstable
fulfills it already.
- same for cmake
- Vcs-Bzr/Vcs-Broswe is to keep the Debian bits of the packaging, not
ot the Ubuntu ones. Maybe put the Debian one on its own branch and
update those fields?
d/copyright
Regarding the license of src/core/util/unicode/*...
Well, this license look weird. The original header from the original
authors in the file says LGPL-2+ and the header added by upstream says
dual-licensing Apache2/LGPL3+ as the rest of the project.) I think that
needs some clarification, as upstream cannot simply re-license a file
with different terms without approval from the original authors. Also,
searching the Net for this files reveals some almost identical copy, so
I think it has not been completely rewritten to void the original copyright.
According Wikipepedia, Apache 2.0 and (L)GPL-2 combined could be problematic,
but IANAL, maybe you should discuss this on debian-legal.
Files: debian/*
Copyright: 2012 Openismus GmbH <http://openismus.com/>
License: GPL-2+
Your name's missing here.
I'd recommend also to use the same license for debian/* as upstream, otherwise it could be
problematic for them to e.g include patches you're going to submit. But as you cannot
relicense yourself and with the company defunct you cannot ask them... Maybe repackage from scratch?
Apropos patches:
They need a dep3 header.
You don't need to install README.rst, as it mostly contains build instructions which are
not neccssary for the binary packages.
The package is not building using pbuilder:
-- snip --
CMake Error at /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:108 (message):
Could NOT find Subversion (missing: Subversion_SVN_EXECUTABLE)
Call Stack (most recent call first):
/usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:315 (_FPHSA_FAILURE_MESSAGE)
/usr/share/cmake-2.8/Modules/FindSubversion.cmake:126 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
CMakeLists.txt:52 (find_package)
-- Configuring incomplete, errors occurred!
See also "/tmp/buildd/lucene++-3.0.6/obj-x86_64-linux-gnu/CMakeFiles/CMakeOutput.log".
dh_auto_configure: cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None -DENABLE_DOCS:BOOL=ON -DENABLE_STANDARD_ALLOCATOR:BOOL=ON returned exit code 1
debian/rules:11: recipe for target 'override_dh_auto_configure' failed
make[1]: *** [override_dh_auto_configure] Error 2
make[1]: Leaving directory '/tmp/buildd/lucene++-3.0.6'
debian/rules:8: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
-- snip --
On Fri, 2014-06-27 at 17:42 +0200, Łukasz 'sil2100' Zemczak wrote:
> Package: sponsorship-requests
> Severity: normal [important for RC bugs, wishlist for new packages]
>
> Dear mentors,
>
> I am looking for a sponsor for my package "lucene++"
>
> * Package name : lucene++
> Version : 3.0.6-1
> Upstream Author : Alan Wright [alan@spotify.com]
> * URL : https://github.com/luceneplusplus/LucenePlusPlus
> * License : LGPL-3+ or Apache-2.0 (mixed)
no, it's dual-licensed.
> Section : libs
>
> It builds those binary packages:
>
> liblucene++-contrib0 - Shared library with Lucene++ contributions
> liblucene++-dev - Development files for Lucene++
> liblucene++-doc - Reference manual for Lucene++
> liblucene++0 - Shared library for Lucene++
How's about providing also a -dbg package?
> To access further information about this package, please visit the
> following URL:
>
> http://mentors.debian.net/package/lucene%2B%2B
>
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x
> http://mentors.debian.net/debian/pool/main/l/lucene++/lucene++_3.0.6-1.dsc
>
> More information about lucene++ can be obtained from
> https://github.com/luceneplusplus/LucenePlusPlus
>
> Changes since the last upload:
>
> * Initial release. Rebased Ubuntu packaging on version 3.0.6
> (Closes: #750148)
>
>
> Best regards,
>
> --
> Łukasz 'sil2100' Zemczak
> lukasz.zemczak@canonical.com
> www.canonical.com
> www.ubuntu.com
>
>
--
tobi
Reply to: