Bug#751534: RFS: crunch/3.6-1 [ITP] -- tool for creating wordlist
* Marcio de Souza Oliveira <m.desouza20@gmail.com>, 2014-06-20, 19:12:
I: Crunch: hyphen-used-as-minus-sign usr/share/man/man1/crunch.1.gz: 75
I changed the description to:
Description: Added backslash before the hyphen option -s at line 75
That's better. But let's remove “at line 75”. :-)
I changed the name of the patch to fix_spelling.
I found more misspellings:
exponentail -> exponential
swedish -> Swedish
outout -> output
supress -> suppress
varible -> variable
calcualated -> calculated
gernerate -> generate
explaination -> explanation
recommneds -> recommends
instad -> instead
japanese -> Japanese
Some of the above are also in debian/changelog.upstream.
Copyright: 2004 ? <mimayin@aciiid.ath.cx>
What's up with this question mark?
Not possible identify the name of first author.
The email mimayin@aciiid.ath.cx not exist.
Then as we could not identify it put that way.
I would write it in a similar way upstream did:
Copyright: 2004 mimayin@aciiid.ath.cx
I put now GPL-2.0+ in debian/copyright
But that's not what upstream says. They say explicitly “version 2 only
of the License”.
Why is README.source shipped in the *binary* package?
So that the end user knows the changelog did not come from the upstream
source code, so I sent along the binary package.
If it's really that important for end users to know (I don't think it
is, but I'm not going to argue about it either), then more obvious place
this is information is the changelog file itself.
Or alternatively, you could extract changelog from crunch.c comments,
therefore making it “official”. :-)
Minor nitpick about error handling in upstream code:
status = rename(fpath, outputfilename); /* rename from START to user specified name */
if (status != 0) {
fprintf(stderr,"Error renaming file. Status1 = %d Code = %d\n",status,errno);
fprintf(stderr,"The problem is = %s\n", strerror(errno));
exit(EXIT_FAILURE);
}
rename() always returns either 0 or -1, so there's little point in
printing the return code.
errno value could change between after the first call to printf(). If
you want to use the same errno in two library calls, you need to save it
to a temporary variable.
(There are more instances of similar code.)
This is nothing serious of course, but you may want to forward it
upstream.
The program can use lzma(1), bzip2(1), and 7z(1), so the package should
probaby have “xz-utils | lzma, bzip2, p7zip-full” in Suggests.
--
Jakub Wilk
Reply to: