Bug#751009: RFS: ppp-gatekeeper/0.1.0-201406091140-1 [ITP]

[Jakub Wilk <jwilk@debian.org>]

Control: tags -1 + moreinfo

[I don't intend to sponsor this package. Sorry!]

* Nigel Kukard <nkukard@lbsd.net>, 2014-06-09, 13:23:
>  ppp-gatekeeper - PPP Gatekeeper

This short description gave me very little clue what this package is 
about...

> http://mentors.debian.net/debian/pool/main/p/ppp-gatekeeper/ppp-gatekeeper_0.1.0-201406091140-1.dsc

The watch file doesn't work:

$ uscan --force-download --destdir .
ppp-gatekeeper: Version (0.1.0-201406091140) available on remote site:
 http://download.allworldit.org/ppp-gatekeeper/v0.1.0-201406091140/ppp-gatekeeper-http://download.allworldit.org/ppp-gatekeeper/v0.1.0-201406091140.tar.gz
 (local version is 0.1.0-201406091140)
gpgv: no valid OpenPGP data found.
gpgv: the signature could not be verified.
Please remember that the signature file (.sig or .asc)
should be the first file given on the command line.
uscan warning: OpenPGP signature did not verify.


debian/copyright says “License: GPL-2+”, but in the source I see “either 
version 3 of the License, or (at your option) any later 
version.”  So is it 2+ or 3+?


The init script does this:

       mkdir -p "${RUNDIR}"
       chmod 750 "${RUNDIR}"

This is racy: malicious local use could open the directory between the 
two calls, and then keep it open as long as they wish. mkdir has the -m 
option to create directories with correct permissions, which you should 
probably use.


The postinst script does this:

       chmod 0750 /var/log/ppp-gatekeeper
       chmod 0600 /etc/ppp/ppp-gatekeeper.conf

This is racy, and potentially stomps on permission set by the user 
via dpkg-statoverride. These files should be shipped in the .deb with 
correct permissions instead.

It also does this:

       chmod 0750 /var/run/ppp-gatekeeper

But this directory doesn't even exist at this point, so the package 
fails to install:

Setting up ppp-gatekeeper (0.1.0-201406091140-1) ...
chmod: cannot access '/var/run/ppp-gatekeeper': No such file or directory
dpkg: error processing package ppp-gatekeeper (--configure):
subprocess installed post-installation script returned error exit status 1
Processing triggers for libc-bin (2.19-1) ...
Errors were encountered while processing:
ppp-gatekeeper
E: Sub-process /usr/bin/dpkg returned an error code (1)

(I'm tagging the bug +moreinfo, because the last bug renders the package 
non-uploadable.)

--
Jakub Wilk