Bug#748674: RFS: ipmitool/1.8.14-1 ITA
Control: tag -1 + moreinfo
On Mon, May 19, 2014 at 7:37 AM, Jörg Frings-Fürst
<debian@jff-webhosting.net> wrote:
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "ipmitool"
>
> * Package name : ipmitool
> Version : 1.8.14-1
> Upstream Author : ipmitool-devel
> <ipmitool-devel-request@lists.sourceforge.net>
> * URL : http://sourceforge.net/projects/ipmitool/
> * License : BSD-3-clause
> Section : utils
>
> It builds those binary packages:
>
> ipmitool - utility for IPMI control with kernel driver or LAN
> interface
>
> To access further information about this package, please visit the
> following URL:
>
> http://mentors.debian.net/package/ipmitool
>
>
> Alternatively, one can download the package with dget using this
> command:
>
> dget -x
> http://mentors.debian.net/debian/pool/main/i/ipmitool/ipmitool_1.8.14-1.dsc
>
>
> Changes since the last upload:
>
> * add debian/ipmitool.ipmievd.default
> - default ipmievd start is disabled
> * add patch
> - 097-source_typo.patch
> - 098-manpage_typo.patch
> * add systemd
> * rewrite debian/copyright
> * add debian/source/format
> * add debian/ipmitool.lintian-overrides
> - possible-gpl-code-linked-with-openssl
> (GPL-2 only in debian/*)
> * debian/control
> - add homepage ( Closes: #744283 )
> - bump Standards-Version to 3.9.5
> - remove unused Build-Depends
> - quilt
> * change to upstream version 1.8.14
> - ( Closes: #725476 )
> - ( Closes: #708387 )
> - ( Closes: #615049 )
> - ( Closes: #627041 )
> - ( Closes: #554348 )
Please be more verbose/descriptive here, i.e. something like:
- Fix FTBFS on kfreebsd (Closes: #725476)
- Include bmcautoconf.sh script (Closes: #627041)
...etc.
Bugs that were fixed in an earlier upstream release (like #708387)
should be closed manually by sending mail to 708387-done@bugs.d.o with
the correct Version: header set (so that they're marked as fixed in
the correct version(s)).
> * Bumps compat to 9
> * New maintainer ( Closes: #748487 )
- debian/copyright: line 67 seems to be out of place (move to line 64?)
- This is entirely up to you, but you could avoid
possible-gpl-code-linked-with-openssl entirely if you chose to license
debian/* under GPL-2+ with the openssl exception clause (instead of
just plain GPL-2+). Also, as debian/* is the only thing that's
GPL-licensed in the entire package, you could also just use the same
license as the rest of upstream's source (3-clause BSD). Assuming you
deliberately chose to license your packaging as GPL-2+, just be
careful of including any non-trivial patches in debian/patches/*, as
that could cause you to run into conflict with
possible-gpl-code-linked-with-openssl.
- A lot of your patches have incomplete DEP-3 headers (it looks like
you've just copied and pasted from a template). Don't forget to
forward your patches upstream if possible.
- If you're going to install systemd service files, please build-dep
on dh-systemd and put "dh $@ --with systemd" in debian/rules (AFAIK
that injects some Debian+systemd-specific integration stuff into your
maintainer scripts). [1]
- debian/dirs and debian/README.source are both redundant (the latter
because you use source format "3.0 (quilt)").
- lintian:
W: ipmitool: manpage-has-errors-from-man
usr/share/man/man1/ipmitool.1.gz 1037: warning [p 13, 4.0i]: can't
break line
Regards,
Vincent
[1] https://wiki.debian.org/systemd/Packaging
Reply to: