Bug#747338: RFS: libonig/5.9.5-1 ITA
On Sun, May 11, 2014 at 1:04 AM, Jörg Frings-Fürst
<debian@jff-webhosting.net> wrote:
> Hello Vincent,
>
>
> Am Samstag, den 10.05.2014, 23:21 -0700 schrieb Vincent Cheng:
>> Control: tag -1 + moreinfo
>>
>> On Wed, May 7, 2014 at 8:42 AM, Jörg Frings-Fürst
>> <debian@jff-webhosting.net> wrote:
>> > Package: sponsorship-requests
>> > Severity: normal
>> >
> [...]
>> >
>> > dget -x
>> > http://mentors.debian.net/debian/pool/main/libo/libonig/libonig_5.9.5-1.dsc
>> >
>> >
>> - debian/control: libonig2 needs to declare Pre-Depends:
>> ${misc:Pre-Depends}. Also, the Replaces: field is unnecessary for
>> libonig2.
> done
No, not done. Please re-read my comment above more carefully (emphasis
on "Pre-Depends:"), or refer to the Debian wiki's guide on
multiarch-ifying packages. [1]
>> - debian/copyright: the link contained in the Source: header doesn't work
> corrected
>
>> - debian/libonig2-dbg.install: obsolete and can be removed, there's
>> nothing but a single commented out line
> removed
>
>> - debian/libonig-dev.docs: you don't need to add debian/README.Debian
>> here, dh_installdocs will automatically install it
> removed
>
>> - debian/README.Debian itself is redundant (it looks like this is a
>> new file since the last upload; I'd suggest moving its contents into
>> d/changelog instead)
> moved to changelog and README.Debian removed
>
>> - debian/rules: why create and install empty NEWS and ChangeLog files?
> At first time I build the package pdebuild stops (at dh_auto_configure?)
> with NEWS and then with ChangeLog not found.
>
>> If upstream doesn't provide changelogs, ignore the pedantic lintian
>> tag; don't add an empty changelog to compensate for it. Also, your
>> override_dh_builddeb target is redundant given that xz is used by
>> default to compress packages nowadays.
> override_dh_builddeb removed.
>
> and uploaded to mentors.
>
Another thing:
W: libonig source: package-depends-on-lower-priority-package
libonig-dev:optional depends on libonig2:extra
Either libonig2 needs to be Priority: optional, or libonig-dev made
Priority: extra.
Regards,
Vincent
[1] https://wiki.debian.org/Multiarch/Implementation#dh.281.29_and_autotools
Reply to: