Bug#744253: RFS: ledgersmb/1.3.39-1 [RC]

[Vincent Cheng <vcheng@debian.org>]

Control: tags -1 + moreinfo

On Sun, Apr 20, 2014 at 7:06 AM, RJ Clay <jame@rocasa.us> wrote:
> Dear mentors,
>
> As my usual sponsor for my ledgersmb package does not appear to be
> available, I am again and still looking for a sponsor for version 1.3.39-1
> of my "ledgersmb" package.

Raphael Hertzog is active according to MIA, so he's probably just a
bit too busy right now to handle RFS requests. Maybe wait a little bit
longer so he has a chance to review your package as well?

> It builds this binary packages:
>
>     ledgersmb  - financial accounting and ERP program
>
> To access further information about this package, please visit the following
> URL:
>
>
> http://mentors.debian.net/package/ledgersmb
>
> Alternatively, one can download the package with dget using this command:
>
>     dget -x
> http://mentors.debian.net/debian/pool/main/l/ledgersmb/ledgersmb_1.3.39-1.dsc
>
>
> More information about LedgerSMB can be obtained from
> http://www.ledgersmb.org.
>

- debian/copyright: the license for tools/prepare-company-database.*
(line 33) should be given a name, not just left blank. The license
block looks pretty much the same to me as a typical 2-clause BSD
license.

- your package FTBFS when built twice in a row:

dpkg-source: info: using source format `3.0 (quilt)'
dpkg-source: info: building ledgersmb using existing
./ledgersmb_1.3.39.orig.tar.gz
dpkg-source: warning: ignoring deletion of file Build.PL
dpkg-source: warning: ignoring deletion of directory LedgerSMB/Entity
dpkg-source: warning: ignoring deletion of directory LedgerSMB/Assets
dpkg-source: info: local changes detected, the modified files are:
 ledgersmb-1.3.39/ledgersmb-httpd-2.0-2.2.conf.template
dpkg-source: error: aborting due to unexpected upstream changes, see
/tmp/ledgersmb_1.3.39-1.diff.IVQ7Ev
dpkg-source: info: you can integrate the local changes with dpkg-source --commit
dpkg-buildpackage: error: dpkg-source -b ledgersmb-1.3.39 gave error
exit status 2

- using wrap-and-sort (from the devscripts package) would make it much
easier to review changes to your package's depends/recommends/suggests

I'd feel a lot more comfortable if your original sponsor could review
this (the maintainer scripts in particular due to their complexity),
as I don't use ledgersmb myself and this is the first time I've looked
at its packaging, but if your sponsor still doesn't respond, say, in
another half month, I'll take a second look at this.

Regards,
Vincent