Bug#744026: RFS: isbg/0.99-1 [#587458]
Am Sonntag, 13. April 2014, 23:13:57 schrieb Paul Wise:
> On Wed, Apr 9, 2014 at 8:38 PM, Werner Mahr wrote:
> > I am looking for a sponsor for my package "isbg"
>
> I don't intend to sponsor this but here is a review:
>
> Please include the manual page upstream and make setup.py install it
> properly.
When I overtook upstream work, I'll do that. For now upstream doesn't exist.
> The url= line in setup.py is incorrectly indented with spaces instead of
> tabs.
Upstream will fix this, when it exists again. As it even doesn't throw a
warning, it can be considerred as working.
> debian/copyright is missing the license information.
Corrected
> debian/copyright contains a bogus URL to different software.
Corrected
> You might want to use the machine-readable copyright format:
>
> https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Converted
> The empty Recommends/Suggests in debian/control are unnecessary.
>
> debian/changelog should only contain one entry not two:
>
> * Initial packaging (Closes: #587458)
Corrected
> I would suggest using the new dh command from debhelper to reduce
> debian/rules to 3 lines, see the dh manual page for examples.
>
> http://manpages.debian.org/man0/dh
> https://penta.debconf.org/dc9_schedule/events/418.en.html
It's 6 lines, as I had to override dh-auto-install because of isbg.egg-info,
like mentioned in the corresponding bug-report.
> Generally DH_VERBOSE is commented out in debian/rules.
Sorry, I forgot this one, beside deleting the commented old content of
debian/rules, will be fixed on next upload, as just this isn't enough for a
new upload.
> The package FTBFS when built twice in a row:
>
> dpkg-source: info: local changes detected, the modified files are:
> isbg-0.99/build/scripts-2.7/isbg.py
> isbg-0.99/isbg.egg-info/PKG-INFO
> isbg-0.99/isbg.egg-info/SOURCES.txt
> isbg-0.99/isbg.egg-info/dependency_links.txt
> isbg-0.99/isbg.egg-info/top_level.txt
> dpkg-source: error: aborting due to unexpected upstream changes, see
> /tmp/isbg_0.99-1.diff.c121eq
> dpkg-source: info: you can integrate the local changes with dpkg-source
> --commit
Fixed.
> Automated checks:
>
> https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
>
> lintian:
>
> I: isbg source: debian-watch-file-is-missing
Added.
> I: isbg: hyphen-used-as-minus-sign usr/share/man/man1/isbg.1.gz:46
Corrected (beside some other and a spelling)
> dpkg-gencontrol:
>
> warning: package isbg: unused substitution variable ${python:Versions}
Removed
> duck:
>
> debian/control: Homepage: http://redmine.ookook.fr/projects/isbg: ERROR
> Curl:28 HTTP:0 Timeout was reached Connection timed out after 60001
> milliseconds
Intresstingly, it's not reachable when ipv6 is available. I can't reach it,
too. But it's the only alternative, beside the github-repo which is less
informative.
> lintian4py:
>
> p: isbg source: insufficient-build-dependency-on-python-helper
> dh_python2 => python (>= 2.6.6-3~)
Fixed
[other errors from lintian4py (from experimental) and pep8 snipped]
I don't know python that well, I'm learning it with maintaining this package
and getting upstream author of it, so I can't right now rate the warnings, but
I use this prog for some time now, and it works like a charm, so I get this
all fixed when overworking the source, but a patch for this would be bigger
than the programm itself and getting it upstream is impossible for now.
> pyflakes:
>
> ./isbg.py:377: undefined name 'imap'
Same as above. This seems to be a false positive for a global var.
--
MfG usw.
Werner Mahr
Reply to: