Bug#739056: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
On 14 March 2014 22:14, Jakub Wilk <jwilk@debian.org> wrote:
> * James McDonald <james@jamesmcdonald.com>, 2014-03-14, 12:01:
>
> An unintended side-effect of passing CFLAGS to make is that now warnings
> (except -Wformat) are no longer enabled. :/
>
> Perhaps upstream could fix their makefile, so that they honour CFLAGS from
> environment? It's a bit odd that they do it with CPPFLAGS and LDFLAGS, but
> not with CFLAGS.
I have added a simple patch to fix this for the time being. The next
upstream tagged release will not be until shortly before OpenBSD 5.6
is released.
>> I replaced it with a binary key. I had called it .php with an armoured key
>> because that made lintian happy.
>
> Nice typo! *giggle*
Doh!
>> I will speak to upstream and try to resolve this. To my mind something
>> like openbsd-cwm or calmwm would make sense.
>
> Great, thanks.
I have modified the package to rename the binary, manual page and
.desktop file to openbsd-cwm, and added a README.Debian to note this
change. I haven't modified the contents of the man pages. Should I do
so? If so, just where the binary name is referenced, or globally?
> I wonder if extracting upstream changelog automatically from README wouldn't
> be a better strategy than manually maintaining a patch.
Good idea. I put the generation in debian/rules.
> I'd prefer if Debian changelog for initial release contained only a single
> entry.
Done.
Cheers,
James
Reply to: