[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#683120: RFS: yadifa/1.0.3-1 [ITP]



Hi,

thanks for the review, Christian!

On 04/05/2014 06:16 PM, Christian Kastner wrote:
> AFAIK bind9 only stores run-time data in /var/cache/bind (from dynamic
> DNS updates, etc). bind9's zone files are in /etc/bind/zones.
> 
> [...]
> 
> I'd either go with /etc/yadifa or /var/lib/yadifa. Check the FHS to
> decide which directory fits best.
> 
> Note that the example debian/yadifad.conf assumes /var/lib/yadifa.

Yes, I had opted for this location as it is not possible to specify
separate dirs for master and slave zones.


> debian/control
> ==============
> Your Homepage field has trailing whitespace.

fixed.

> If you're using a VCS for your packaging, Vcs-* URLs would be nice (to
> simplify contributing to your packaging). You can also use
> Debian's infrastructure, see [1].

I had intended to set up a repo after the first upload. But of course it
is easier to contribute even before that. And since I need a DM approval
for an Alioth repo, I settled for github for now.

> The Section field of yadifa-dev should be: libdevel.
> You're providing static libraries in the -dev package, but not a shared
> library package. This is not necessarily wrong, just unusual. Note
> that the configure script has an option to build a shared library.

Good point. The default was to do static linking. Now with shared libs,
I have not just two packages but five (three just for the libs). But as
the recent openssl bug shows, it is easier to just patch a lib than to
rebuild all depending packages.

> debian/copyright
> ================

I had originally just included upstreams COPYING, but I think it's safe
to extend the years to include all changes from upstream since then.

As for my own packaging, I don't mind putting it under a BSD-style license.

So again, after making these various adjustments and corrections, I have
re-uploaded the package again.

To access further information about this package, please visit the
following URL:

http://mentors.debian.net/package/yadifa

Or via dget at

http://mentors.debian.net/debian/pool/main/y/yadifa/yadifa_1.0.3-1.dsc

Regards,

Markus


Reply to: