Bug#741501: RFS: libb2/0.96-1 [ITP]
Hi,
On 2014-03-13 05:57, Robert Ransom wrote:
> I am looking for a sponsor for my package "libb2":
I'm not a DD so I can't sponsor your package, but here is a quick review:
Building
========
There is one troublesome aspect of the upstream code: AFAICT,
CPU-specific optimizations such as MMX, SSE, etc. are detected and
enabled at compile-time.
That is a problem because your binary packages will end up with
optimizations specific to the buildd they were built upon, but the
platforms they will run upon might lack support for those optimizations.
I suggest you either verify that this is not a problem (eg run-time
support detection) or disable some of those optimizations.
The debian-kernel@l.d.o will probably be able to you which instruction
sets you are allowed to assume as always present in certain
architectures (eg "amd64 always has MMX" or some such).
debian/control:
==============
Build-Depends: debhelper (>= 9), not debhelper (>= 9.0.0). IIRC there
exists a (written or unwritten) rule for when one can/should truncate
version numbers, but I can't find a source for that at the moment so I
could be wrong. Regardless, debhelper(7) recommends this.
You do not need to specify the Section: for binary packages if the
intended Section matches the source package section, so the "Section:
libs" can be omitted from binary package libb2-1.
If you're using a VCS for your packaging, it would be nice if you could
include Vcs-* URLS pointing to the repository. This simplifies
contributing to your packaging.
debian/copyright:
=================
I'd add the Upstream-Contact field to the header section using the
address you specified in the ITP.
debian/rules:
=============
You can drop the "Sample debian/rules that uses debhelper" part.
Later releases (somewhat more advanced topics)
==============
You could generate minimal dependencies by creating using a symbols
file, see
https://wiki.debian.org/UsingSymbolsFiles
You could install lintian overrides to silence a couple of informational
and pedantic warnings, see
$ lintian -I --pedantic *.deb *.dsc
HTH,
Christian
> To access further information about this package, please visit the
> following URL:
>
> https://mentors.debian.net/package/libb2
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x https://mentors.debian.net/debian/pool/main/libb/libb2/libb2_0.96-1.dsc
>
> More information about libb2 can be obtained from <https://blake2.net/>.
Reply to: