On Sun, 2014-02-16 at 15:19 +0400, Sergey Kirpichev wrote: > I hope, that's fixed in: > http://anonscm.debian.org/gitweb/?p=collab-maint/awstats.git;a=commit;h=9c8f27ceb7f9490387a32b9fb2f45b21f69f853d It doesn't have any privacy issues, but: It is utterly pointless to include a 1x1 tracking gif in a source package. The whole point of 1x1 GIFs is privacy violation and since you can't violate privacy locally they are pointless, just delete that. Not sure if it makes sense to have <input type="image"> without the image in it. Please replace that with type="submit" and drop the border. > Could you kindly provide a more detailed *technical* > suggestion in this case (facebook patch)? This has PHP code for computing the URL but it should be easy to replace that part with a link to the page @ http://awstats.sourceforge.net/docs/ https://stackoverflow.com/questions/10988815/facebook-twitter-and-google-1-buttons-using-only-html-no-javascript > It's not reasonable to believe, that every maintainer would read all > provided in the package *.html files in a regular way to find and fix > such problems. Without automation - it's just a waste of time. I didn't mention detection at all. My objection was that your message implied you wouldn't fix these issues I detected and informed you about until lintian was fixed to detect the issues I detected manually. Sorry if I wasn't clear enough about that. BTW I'm surprised you also didn't detect this issue when writing the patches you wrote initially. > btw, I think google/twitter problems are gone in the last upload: > http://anonscm.debian.org/gitweb/?p=collab-maint/awstats.git;a=blob;f=debian/patches/2007_googleplus.patch > http://anonscm.debian.org/gitweb/?p=collab-maint/awstats.git;a=blob;f=debian/patches/2008_twitter.patch Personally I would use this instead: https://stackoverflow.com/questions/10988815/facebook-twitter-and-google-1-buttons-using-only-html-no-javascript I see that index.html has a privacy violation in the form of a Google SiteSearch JavaScript. Lintian doesn't detect it, filing a bug about it. -- bye, pabs http://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part