Bug#738581: RFS -- speedtest-cli - A command line client for the speedtest.net
On Thu, Feb 13, 2014 at 10:35 AM, Jonathan Carter (highvoltage)
<jonathan@ubuntu.com> wrote:
> On 13/02/2014 00:26, Andrew Starr-Bochicchio wrote:
>> I'd be happy to sponsor this package. Here's a quick review:
>
> Thanks! I've made the changes as requested. Let me know if there's
> anything further that needs fixing and I'll do so as soon as I can.
Alright, I know this is nit-picky, but here's how I would have written
the Files paragraphs of debian/copyright:
"""
Files: *
Copyright: 2013, Matt Martz <matt@sivel.net>
License: Apache-2.0
Files: debian/*
Copyright: 2014, Jonathan Carter <jonathan@ubuntu.com>
License: Apache-2.0
License: Apache-2.0
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
.
http://www.apache.org/licenses/LICENSE-2.0
.
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
.
On Debian systems, the complete text of the Apache License 2.0 can
be found in "/usr/share/common-licenses/Apache-2.0"
"""
You can use a "stand alone" license paragraph if multiple files
paragraphs share a license.
Also, is the packaging in version control somewhere? If so, please
include Vcs fields in debian/control. If not, you might consider
joining the Python Application Packaging Team. [0]
Besides that, it looks ready to upload!
[0] https://wiki.debian.org/Teams/PythonAppsPackagingTeam
-- Andrew Starr-Bochicchio
Ubuntu Developer <https://launchpad.net/~andrewsomething>
Debian Developer <http://qa.debian.org/developer.php?login=asb>
PGP/GPG Key ID: D53FDCB1
Reply to: