[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#738671: RFS: whatmask/1.2-1 [ITP]



Hi Daniel,

Thank you for the kind words and for pointing out those lintian warnings - I'll investigate and look at resolving them.

Thanks also for the watch file - I'll see if I can make any changes and will incorporate that into the package :-)

Regards,
Nick

On 11 Feb 2014 21:37, "Daniel Lintott" <daniel@serverb.co.uk> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Nick,

Disclaimer: I'm not a DD, so can't upload your package but have looked
at it, as it is of interest to me.

Generally the package seems to be in very good shape and builds in a
clean chroot fine.

Just touching on the couple of lintian warnings:

> X: whatmask source: deprecated-configure-filename

I would forward this to upstream for their attention [1]

> I: whatmask source: debian-watch-file-is-missing

I have attached a watch file that seems to work okay (other watch file
guru's may be able to optimise it). As upstream sign their releases,
you can get uscan to check [2] this as well. I have included the line
to check this in the watch file (again, it might not be perfect)

The releases have been signed with key ID: E8882FE3

> I: whatmask: spelling-error-in-binary usr/bin/whatmask GNU PUBLIC
> LICENSE GNU General Public License

This will be easy enough to patch and again forward upstream. The
error appears in usage.c:60

Hope this review is helpful for you and aids you in finding a sponsor.

[1] http://lintian.debian.org/tags/deprecated-configure-filename.html
[2]
https://wiki.debian.org/debian/watch/#Cryptographic_signature_verification
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQEcBAEBAgAGBQJS+pgdAAoJEMw/9yOWzAkJg4AH/RiyxLX1IvkOCHGqfnAyhoED
cLNI6BUp6TXHqa11//nySvrSoHrIhBgY+ZJvO+d1WmoUzMI0MShcTC91mUYKgOIi
2zJDOK9PapwK3e7PJGHnIJP9jGykD2OaeEvCIC4LMp2OeAw1sE5K1z2tBDHxCDHL
ll6JU7pQsRPFBB/UpuaRvCUScyj+VVLbE1uX1XsK3TivI2naKOeQtuH/pKKiJcz+
VFrNLx6TZFPQe3v96e+RK+yUnwdNjTEaurXPKyiV/Rbk/bEvDIY5CWPQZNGWzZ0c
3P0CdQNF2Ci8kxaGTDyR1+1cza4GwRS9iFlqXZ/BSby92y3zzYZ4EpQD0//UDC8=
=OtT3
-----END PGP SIGNATURE-----

Reply to: