Bug#737682: RFS: rpmlint/1.5-1 [ITP]
Hi there!
thanks for your time and review. Some comments below.
On 5 February 2014 05:19, Paul Wise <pabs@debian.org> wrote:
>
> How you intend to use this package - what is your motivation for
> wanting this in Debian?
>
In Debian we have all the necessary to develop, build and distribute
RPM packages. However, a point is missing: a basic package check (what
lintian does in the Debian world).
I use Debian servers for all I said (build, develop, distribute...)
and I strongly want this tool in Debian as I think it will enrich and
complement a Debian serving for this purposes.
I guess a big portion of the users of the rpm suite on Debian are
going to find this very useful [0].
> A review:
>
> The blank line and comment in debian/watch are not needed.
>
fixed.
> Why did is the test suite disabled in debian/rules?
>
fixed.
> Please send the manual page for rpmdiff upstream.
>
Of course, that is the plan.
> The README.devel file is not needed in the binary package.
>
fixed.
> The copyright file is missing a stanza for debian/* and for some
> upstream copyright holders.
>
I think the debian/* notice is not necessary any more, since 3.9.3.
For almost all files, Frédéric Lepied is the copyright holder, or Ville Skyttä.
Other developers are mentioned in the AUTHORS file, but they don't
seem to hold any copyright.
Could you please elaborate what should I do here?
> Please remove __version__.py and __isocodes__.py in `debian/rules
> build` to ensure they can be recreated at build time.
>
fixed.
> The upstream Makefile installs rpmdiff to /usr instead of /usr/local
> when you build from source. Please ask upstream to support installing
> to an arbitrary prefix and default to /usr/local (the Debian packaging
> would then override that to /usr).
>
OK.
> Automated checks:
>
> https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
>
> lintian:
>
> P: rpmlint source: debian-watch-may-check-gpg-signature
>
Can't be easily solved. I will contact upstream. I added an override.
> pep8:
>
> Lots of warnings.
>
This is something I will definitely submit to upstream.
Thanks for the review, find a new version in mentors [1] (please wait
a few minutes, I just order the upload).
regards
[0] http://qa.debian.org/popcon.php?package=rpm
[1] https://mentors.debian.net/package/rpmlint
--
Arturo Borrero González
Reply to: