[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#737390: RFS: kerneltop/0.91-1 [ITA]



Interesting package, this is my review:

1 upstream ships manpage, so please remove debian/kerneltop.1
2 3.0 (quilt) always use quilt to manage patches, so README.source is
meaningless, please remove
3 Upstream makefile don't use CFLAGS environmen which includes  build
harden flags. I advice you pach "CCFLAGS=-g/-s" in makefile with
"CCFLAGS=-g/-s $(CFLAGS)" to include build harden flags and remove
debian/source/lintian-overrides
4 Please update debian/copyright with DEP5 format[2].

Thanks for your working on debian.


[1] https://wiki.debian.org/Hardening
[2] http://dep.debian.net/deps/dep5/

-- 
Liang Guo
http://guoliang.me


Reply to: