Bug#736655: RFS: napi-bash/0.31.1-1 [ITP]
I can't promise I'll sponsor this package, but here's a preliminary
review:
* Mateusz Łukasik <mati75@linuxmint.pl>, 2014-01-25, 20:46:
http://mentors.debian.net/debian/pool/main/n/napi-bash/napi-bash_0.31.1-1.dsc
Instead of using debian/dirs, I'd rather fix the upstream makefile, so
that it doesn't explode when the directories are missing.
Nitpick: it should be "REAME.Debian" rather than "README.debian".
While this package is technically marked "any",
I think you meant s/any/all/.
it will only function correctly in linux or BSD/kFreeBSD systems (This
namely excludes Hurd)
Why is "BSD" and "Hurd" capitalized, but "linux" is not? :)
Why doesn't it work on Hurd?
Could you get the package description and README.Debian reviewed by
debian-l10n-english@ldo?
Don't use compression level 9 for xz. It makes dpkg use ridiculous
amounts of memory, and for small files like this package's .debian.tar
or data.tar it doesn't even improve compression ratio.
rm -rf debian/napi-bash/usr/share/man/{,pl
An unmatched left curly bracket creates an unresolved tension that will
stay with you all day. Besides, {,} is a bashism.
Rather than override the Lintian tag, I'd fix the underlying problem.
Please consider applying the attached patch, which lets groff break the
long line.
This line smells awfully like a security hole:
local dlfile="/tmp/napis.$md5.7z"
Manpages in /usr/share/man/manN/ should be written in English.
The Polish manpages could use spell-checking:
Kombinajca -> Kombinacja
noepobranych -> niepobranych (or "nie pobranych"; I prefer the latter, traditional spelling)
pojedyńczego -> pojedynczego
istnije -> istnieje
nadpisująć -> nadpisując
--
Jakub Wilk
Reply to: