[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]



Hi Vincent,

Thanks for the quick answer.

> How is this different from gnome-shell-timer, which is already
> packaged in debian?

The difference is that it uses pomodoro technique. It's not just a timer.
For more information about the pomodoro technique, you can begin with
the readme of the package
(https://github.com/codito/gnome-shell-pomodoro/blob/gnome-3.8/README.md)


> Anyways, here's a quick review of your package:
>
> debian/control:
> - Vcs-Browser is present, but not Vcs-Git?

I don't have a git:// url on github. I don't know what to use instead.

> Also, ideally your
> packaging would be hosted on alioth, although I don't think there's
> anything in Policy that prohibits it from being hosted elsewhere.

I don't have the rights to create a repo on alioth. I was waiting to
prove myself against Debian dev before finding a sponsor and getting
a real account in alioth.
If you create a repo and give me rights on it I'll put it on alioth with
pleasure.

> - Standards version needs a bump to 3.9.5

Updated.

> - Why "Architecture: any" if there aren't any arch-specific files in
> your package?

As it means any architecture supported by debian and that it is the "most
frequently used" regarding debina policy 5.6.8. I thought it could
stay like this.
What's your advice for this?
Use "all" instead of "any"?

> - Description synopsis (the short one-liner) should be <60 chars (Policy 3.4.1)

Actually it's 80 chars but You're right it was too long. I shorted it.

> debian/README.source is empty, just remove it

Removed.

> debian/watch is missing

I added it. But be carefull, this generates warnings telling you
there's a newer version of the package available.
But the new versions are ONLY compatible gnome-shell 3.9 and 3.10, not
build in debian yet.

The updated package has been updated to mentors:
http://mentors.debian.net/debian/pool/main/g/gnome-shell-pomodoro/gnome-shell-pomodoro_0.8.0-2.dsc

Thanks for your help,
Joseph


Reply to: