Hello,
I have no right to upload, but I'm interested in "nftables" also.
therefore, I have both dget and git clone your source package for
testing and reviewing.
Below is my review.
* debian/control:
+ could bump the standards-version to 3.9.5 as lintian has warned right now.
(found a revert commit in git :P)
+ cosmetic, please apply wrap-and-sort -sa
* debian/copyright:
+ forgot the debian/* license
+ the upstream license could be GPL-2+ as mention in the COPYING file
* debian/watch:
+ I know you plan the watch file for the upstream first release but
it could be changed later, for my suggestion is
=== 8< ===
opts=uversionmangle=s/^/0.0.0~/ \
http://ftp.netfilter.org/pub/libnftables/snapshot/libnftables-(\d\S*).tar.bz2
=== 8< ===
just track the snapshot tarball, I know it's nonsense but it's not
broken watch file :)
* vcs-git:
+ cloned, the "git buildpackage -S" is failed. the upstream tag
<< upstream/0.0.0_20131209 >> is missing.
Hopefully, the package will be sponsored soon. Good luck.
Best regards,
Neutron Soutmun
Attachment:
signature.asc
Description: Digital signature