On Sat, 21 Dec 2013 21:30:28 +0100, Andreas Rönnquist <gusnan@gusnan.se> wrote: > > I've just got a couple of comments: > > * debian/repack is nice but seems like an awful lot of effort to > > remove two files; have you noticed the new Files-Excluded header in > > debian/copyright which uscan now supports? > > Ah, I hadn't - thanks! Well, I am kind of irritated on that bug I > mentioned in README.source (##635920) which makes it impossible to use > git-import-orig --uscan in combination with a debian/repack script... I > guess using the mentioned Files-Excluded would solve this? I haven't actually got round to using it myself yet, so I can't say for sure... But I get the impression that uscan repacks the original tarball itself with the same name when removing excluded files, so it should work transparently with git-import-orig --uscan. I'll leave it to you to decide what you want to do for this version of the xye package, since it's too late for the 0.12.2 import anyway, and it would require rewriting debian/copyright in machine-readable format. > > * The manpage doesn't follow the typical Unix manpage style, although > > if there are no command-line options then the text you've written is > > good enough. You might get bug reports requesting the manpage to > > document how to play but until then... > > I'll think I'll wait for those bug reports... ;) That's fine by me! > > Incidentally while trying to determine whether xye takes any > > command-line parameters, I discovered that specifying any parameter > > causes xye to crash! (I'll file a bug...) > > Oh! I have managed to include a patch that fixes this problem, but when > doing so I found more related problems - if running with a folder which > doesn't contain any data files it still segfaults (but later). I > will try to put together a patch for this problem too. > > (I have pushed my current changes to alioth). > > Would you like me to put together a new package on mentors, or do you > simply get the gbp packaging from alioth? I'm pulling your packaging from alioth, so no need to update mentors. BTW I noticed in your email to debian-devel-games that you mentioned the "newer-standards-version" lintian warning; this is fixed in the latest version of lintian, currently available in unstable only. I recommend that for Debian development work you always use the unstable version of lintian; I use the following apt pinning (in /etc/apt/preferences): Package: lintian Pin: release a=unstable Pin-Priority: 500 Package: debian-policy Pin: release a=unstable Pin-Priority: 500 Let me know when you reckon you've finished preparing the package, whether or not you fix the second segfault you mention (I can't reproduce it, but I may not be testing the right thing). Regards, Stephen
Attachment:
signature.asc
Description: PGP signature