Bug#730306: RFS: tryton-modules-timesheet-cost/3.0.0-1 [ITP]
Hi Mathias,
On Fri, Nov 29, 2013 at 01:41:53PM +0100, Mathias Behrle wrote:
> > Could you please explain why you recompressed the (small sized) upstream
> > tarball. Was anything removed. If you want to push something md5sum
> > different than it is provided by upstream please document this either in
> > text od better code (get-orig-source target).
>
> The recompression of the upstream tarball is just done the same way for all
> modules independent of their size to have a common handling for all Tryton
> packages.
Just doing "the same thing for all tarballs" is no "good reason" (tm) in
my eyes. Please discuss this on debian-devel list.
> The recompressed tarball used for the build can be obtained by pristine-tar list
> and pristine-tar checkout.
That is not the point. You create extra work for people who might
wonder what could be the difference between upstream and Debian archive.
It is called *orig*.tar for a reason and you should not repack this just
for weak reasons. Good reasons are removing non-DFSG compatible stuff.
If this is never the case for any tryton module I'd suggest to never
repack any of them.
> And therefore the question arises for me, if a get-orig-source target is really
> the way to go, because AFAIS md5sums could be different for each download and
> recompression of the tarball.
That's why you should not recompress at all.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: