Bug#721424: RFS: pentobi/7.1-1
Sat, 23 Nov 2013 09:20:39 +0800
Paul Wise <pabs@debian.org> kirjoitti:
> On Sat, Aug 31, 2013 at 7:36 PM, Juhani Numminen wrote:
>
> > I am looking for a sponsor for my package "pentobi".
>
> Uploaded, thanks for taking care of the package.
>
> Here are some things you might want to look at:
I will, and I’ll investigate the failed builds on some architectures
as well.
> Please send upstream these links.
>
> http://tieguy.org/blog/2012/03/17/on-the-importance-of-per-file-license-information/
> http://wiki.debian.org/UpstreamGuide
Okay.
> You might want to run tagpending after closing bugs in
> debian/changelog in future.
>
> There is a newer Debian policy out recently.
>
> http://www.debian.org/doc/debian-policy/upgrading-checklist
I’ll update it.
> Don't list lintian tags in the patch's Subject, that is for the
> description
I’ll fix those.
> What do you think about enabling the KDE thumbnailer?
I missed the fact that there are two thumbnailers. I see no reason to
keep it disabled.
> Might want to add a debian/upstream file.
>
> https://wiki.debian.org/UpstreamMetadata
I can add this file, but are you aware of its uses other than to
“display bibliographic information about which academic article to
cite”? Also as pointed out earlier, DEP12 isn’t available.
> Some of the PNG and ICO images were or look like they were created in
> SVG format, they should be rendered from the SVGs at build time
> instead. Preferrably upstream would remove them from the tarball and
> VCS but if they are unwilling to do that they should be removed before
> dh_auto_configure is run.
>
> Likewise I wonder if there is any way to generate the screenshots at
> build time so they look correct for the version of pentobi that is
> being built.
I will talk to the upstream about these points on the pentobi-devel
mailing list.
> Please upload a screenshot for the new version.
>
> http://screenshots.debian.net/upload
It has been uploaded.
> lintian
>
> P: pentobi: no-upstream-changelog
I could probably just rename /usr/share/doc/pentobi/NEWS to
changelog, would it be ok?
> cme
>
> [...]
> Synopsis is too long.
Seems that I have figure out a shorter one.
> pep8
> [...]
I have sent a patch to upstream.
Thanks,
-- Juhani
Reply to: