[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#726835: RFS: qgit/2.5-2 [RC]



>>>  I still don't think it's a problem of qgit (or any other package providing
>>>  this MimeType, such as easytag or gwenview).
>>  Still? I don't see your opinion in bug report. Please send your comment there.
>>  And do not forget to Cc the submitter: he will be able to write other arguments
>>  or he will agree with you.
>
> I've discussed this situation on #-devel on 2011-12-03 (tumbleweed was
> present). We couldn't decide anything useful though (apart from lindi not
> being able to reproduce the problem, see his mail at #611938).
> There were at that time at least #611938, #398999, #538093, since then
> there may be some new bugs opened and the same can be applied to any other
> package providing this MimeType, such as easytag or gwenview (nowadays you
> probably can use codesearch.d.n to find all such packages).

I was not aware of that discussion and similar bug reports in other packages.
Thanks for the links.

> I guess I should just close this bug as MimeType: inode/directory should
> be present for apps acting as directory viewers and if that causes
> problems with DEs/file managers people should open bugs for them. Though
> all other similar bugs should be closed in the same manner too.

Yes, probably it will be better to close bug report with short description of
the reason.

>>>>   Lintian show one tag, which is easy fixable as well:
>>>>   I: qgit: desktop-entry-lacks-keywords-entry usr/share/applications/qgit.desktop
>>>  I don't think the maintainer should, or even can, add Keywords to upstream
>>>  .desktop files (as opposed to Categories).
>>  Upstream does not provide the the .desktop file. You provide it in debian
>>  subdirectory:
>>  http://anonscm.debian.org/gitweb/?p=collab-maint/qgit.git;a=blob;f=debian/qgit.desktop;hb=HEAD
>
> All the more reasons not to touch Keywords then, I guess.

I do not see the logic here.

>>>  See also "Whether the desktop
>>>  file needs to have a Keywords line added is somewhat subjective." (from
>>>  https://wiki.gnome.org/GnomeGoals/DesktopFileKeywords ).
>>  While it is not obligated, it is really easy to add one line in .desktop file
>>  to make few GNOME users more happy. Something like [1] should be enough I
>>  think.
>>
>>  [1] Keywords=RevisionControlSystem;VCS;DCVS;git;
>
> I have only a slight idea how is this field used in practice and I
> wouldn't test it but if you insist I can add this (after changing "DCVS"
> to "DVCS" and "RevisionControlSystem" to "revision control system").

No problem here. Just add what you think is necessary.

Also it is only a suggestion. I may upload your package even in current state,
if you are strongly against of Keywords field.

Best regards,
Boris


Reply to: