Dear future maintainer, On Thu, Sep 19, 2013 at 11:41:32PM +0200, Richard Sellam wrote: > * Package name : phabricator > Version : 0.1~git20130909-1 As discussed on IRC, you probably want to use 0.0~... or 0~... as the start of the version number. Some other comments: 1. Your description could use some wordsmithing. Specifically, the homepage can be omitted. Explaining that this is a code snapshot may also be beneficial. 2. Please drop the Vcs-Git and Vcs-Browser lines or correct them to be the valid links for the VCS repository corresponding to the packaging. 3. As a nit: it would be advisable to license debian/* under the same terms as upstream, even though this is not a strict requirement. 4. Reference the version of the Apache License in common-licenses from debian/copyright rather than including the license in the package. 5. Please remove libphutil/src/parser/xhpast/bin/xhpast.exe from the upstream tarball. 6. Since you're already creating the upstream tarball, please either implement a get-orig-source target in debian/rules, or document how the tarball was constructed in debian/README.source. You may find it helpful to include the git ref used to build the tool in the package version. 7. Please fix all of the lintian errors marked "Warning" that are listed at https://mentors.debian.net/package/phabricator. The first one (embedded library) could probably be fixed by switching to libphp-phpmailer. 8. Please see whether the things in /usr/share/phabricator/externals can be removed from Phabricator and the appropriate package depended on instead. 9. Please expand debian/copyright to ensure you document the license of all software in the source tarball. If you don't use something in phabricator/externals (because you've done №8), feel free to strip it out of the upstream tarball as long as you document it according to №6. Since Phabricator is a continuous release, are you comfortable backporting security and bug fixes to stable, if the package were accepted? Cheers, -- Luke Faraone;; Debian & Ubuntu Developer; Sugar Labs, Systems lfaraone on irc.[freenode,oftc].net -- http://luke.faraone.cc PGP fprint: 5189 2A7D 16D0 49BB 046B DC77 9732 5DD8 F9FD D506
Attachment:
signature.asc
Description: Digital signature