[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#724807: RFS: yt/2013.09.28-1 [ITP]



Hallo Rich,

A short review: (I am not a DD/DM, so I cannot upload.)

I think "yt" as a package name is too short and well can cause
collisions down the road, please consider renaming it (and the
executeable) How about youtube-cli?

Your package has linitian warnings, please fix them.
You should also not put your .git directory in your tarball

d/README.source IMHO the workflow on the debian packaging repository
should be compaptible with git-buildpackage, then this file is 
not needed. 

I cannot find the upstream location of the tarball, but we'll
need one. There is also no get-orig-source target to regenerate 
the upstream tarball.

There is an extra License: MIT paragraph in d/copyright (line 13+14)

d/rules: your overrides seems not to be needed: You  execute in the
overriden target same dh_* command.

Ask upstream to provide a changelog.

The package does not build two times in a row:
dpkg-source: info: local changes detected, the modified files are:
 yt-2013.09.28/src/whitey.egg-info/PKG-INFO
 yt-2013.09.28/src/whitey.egg-info/SOURCES.txt
 yt-2013.09.28/src/whitey.egg-info/dependency_links.txt
 yt-2013.09.28/src/whitey.egg-info/entry_points.txt
 yt-2013.09.28/src/whitey.egg-info/not-zip-safe
 yt-2013.09.28/src/whitey.egg-info/top_level.txt

Best regards,
coldtobi



Linitian output (cleaned up a little)
P: yt source: source-contains-git-control-dir .git
P: yt source:
source-contains-prebuilt-windows-binary .git/objects/15/60a4fb268be93a02f03b3b0c1c2a6c9a4fcd81
 (many of those follows)
W: yt source: out-of-date-standards-version 3.9.3 (current is 3.9.4)
I: yt source: debian-watch-file-is-missing
P: yt: no-upstream-changelog
I: yt: spelling-error-in-manpage usr/share/man/man1/yt.1.gz prefered
preferred
I: yt: spelling-error-in-manpage usr/share/man/man1/yt.1.gz prefered
preferred
I: yt: hyphen-used-as-minus-sign usr/share/man/man1/yt.1.gz:30
I: yt: hyphen-used-as-minus-sign usr/share/man/man1/yt.1.gz:38
W: yt: binary-without-manpage usr/bin/pi-yt





Am Samstag, den 28.09.2013, 01:46 -0500 schrieb Javier P.L.:
> Package: sponsorship-requests
> Severity: normal whislist
> 
> I am looking for a sponsor for my package "yt"
> 
>  * Package name    : yt
>    Version         : 2013.09.28-1
>    Upstream Author : Rich Wareham <rjw57@cantab.net>
>  * URL             : https://github.com/rjw57/yt
>  * License         : MIT
>    Section         : web
> 
>   It builds those binary packages:
> 
>     yt    - command-line YouTube client
> 
>   To access further information about this package, please visit the following URL:
> 
>   http://mentors.debian.net/package/yt
> 
>   Alternatively, one can download the package with dget using this command:
> 
>     dget -x http://mentors.debian.net/debian/pool/main/y/yt/yt_2013.09.28-1.dsc
> 
>   Changes since the last upload:
> 
>   Initial release, closes: #724801.
> 
>   Regards,
>    Javier Lopez
> 
> 


Reply to: