[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#723570: RFS: skippy-xd/0.5.1-1 ITP



Hi Martin,

I’m not a DD, so I can’t sponsor you, but I have some notes about this
package.

* Where do you download the source tarball skippy-xd_0.5.1.orig.tar.gz?
  I can’t find it in Google Code or GitHub[1]. Please also add a watch
  file.

* Use the “3.0 (quilt)” format[2]:
  - Add d/source/format file containing “3.0 (quilt)”.
  - Drop d/README.source.
  - Drop build-dependency on quilt.
  - Drop “--with quilt” from d/rules, dh $@ should be enough.

* d/control:
  - Please wrap the lines to about 80 chars.
  - debhelper (>= 9) is more common than (>= 9.0.0).
  - If this Debian packaging has isn’t in a VCS, you can remove the
    commented out lines.
  - Manual library depends are not needed.

* d/patches/fixmakefile.patch:
  - Why not fix Makefile trying to use git repeatedly?
  - The PREFIX can be fixed using the override target in d/rules, just
    add “PREFIX=/usr” between DESTDIR and install.
  - The GitHub version already has a similar patch applied.
  - It should be tagged according the DEP3 guidelines[3].

* Upstream has a DEBIAN directory and a DEBIAN/control file. It is
  from a binary package, not a source one. I think it isn’t useful
  to anyone. You can ask upstream to remove the DEBIAN dir.

Regards,
--
Juhani Numminen

[1] https://github.com/richardgv/skippy-xd
[2] https://wiki.debian.org/Projects/DebSrc3.0
[3] http://dep.debian.net/deps/dep3/


Reply to: