Bug#721839: RFS: musl/0.9.13-2 [ITP]
Hi Anton
Thanks for your fast feedback. I have revorked the files according to
your comments. Answers are in the text. I have not uploaded a new
package to Debian mentors. But changes can be found under:
https://github.com/wermut/musl/tree/master/debian
If you have furter questions. I am ready to answer.
Thanks in advance
Kevin Bortis
On Fri, Sep 20, 2013 at 8:46 PM, Anton Gladky <gladky.anton@gmail.com> wrote:
> Hi Kevin,
>
> thanks for working on the package. Generally it looks
> good and almost ready for uploading. Some minor notes:
>
> - Remove Readme.Debian, it is useless.
Done
> - Changelog should have just one note: "Initial packaging, Closes...".
First debian/changelog entry closes ITP
Last debian/changelog closes RFS
OK like this?
> The package was not yet uploaded into Debian.
> - The package number should be 0.9.13-1
Could I still keep the incrementation, because the earlier versions
are already tagged & signed in the public git repository and also
already uploaded to a Ubuntu PPA? (ppa:bortis/musl) So the first
version for uploading would be 0.9.13-3 if you accept. Or we can wait
for musl 0.9.14 wich, according to upstreams roadmap, will be released
in the next two weeks to get a clean 0.9.14-1.
> - Are you sure, you need to ship *.a for further static linkage? Just
> a question. I personally prefer not to do it.
One of the advantage of musl libc is, that it correctly handles static
linking. So I personally prefer to ship these to the users.
> - debian/rules:
> * remove commented lines 2-7
Done
> * do you really need lines 32-39, (Cross build support)
Would appreciate to leave them in package, because I often cross
compile packages. I tried to follow the instructions from
https://wiki.debian.org/CrossBuildPackagingGuidelines
> 41-48, ( Clear CFLAGS, CPPFLAGS and LDFLAGS)
The problem is, that musl is a C library and therefor one of the core
building blocks that must be right. The standard values supplied on
some of the tested architectures (inkl. armhf and amd64) will cause
the libc to segfault on some circumstances because it got build with
wrong FLAGS. I added thes lines, so that musl's configure script can
decide on these very delicate settings. (I have discussed that with
upstream)
54-55?
Needed because cross compiler will not get picked up if not set. Moved
line to the other cross build stuff.
> * add --parallel option to dh
Done.
> * overriding dh_auto_build in your case is not needed.
Done. Removed this part.
> * passing --prefix=/usr in configure is
> - overriding lintian info-warnings not needed.
Done. Removed --prefix=/usr
>
> I may be wrong on some points.
>
> When you fix those notes, please, let me know.
>
> Best regards,
>
> Anton
>
>
> 2013/9/20 Kevin Bortis <pkgs@bortis.ch>:
>> Package: sponsorship-requests
>> Severity: wishlist
>>
>> Dear mentors,
>>
>> I have updated the packages to adress the last lintian warning about
>> the missing manpage. Musl is a new standard C library, almost written
>> from scratch. It is small like uclibc, but is mostly glibc compatible.
>> For more information: http://www.musl-libc.org/intro.html
>>
>> I would really appreciate if someone could at least hint me, if
>> something with the package is wrong and therefor not qualify for
>> uploading.
>>
>> * Package name : musl
>> Version : 0.9.13
>> Upstream Author : Rich Felker <dalias@aerifal.cx>
>> * URL : http://www.musl-libc.org/
>> * License : MIT
>> Section : libs
>>
>> It builds those binary packages:
>>
>> musl - standard C library
>> musl-dev - standard C library development files
>> musl-tools - standard C library tools
>>
>> Related ITP Bug is:
>>
>> #713072
>>
>> To access further information about this package, please visit the
>> following URL:
>>
>> http://mentors.debian.net/package/musl
>>
>> Alternatively, one can download the package with dget using this command:
>>
>> dget -x http://mentors.debian.net/debian/pool/main/m/musl/musl_0.9.13-2.dsc
>>
>> The git repo for the package is located on github:
>>
>> https://github.com/wermut/musl
>>
>> The repository follows the guideline found under
>> https://wiki.debian.org/PackagingWithGit
>>
>> Thanks in advance
>> Kevin Bortis
>>
>>
>> --
>> To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
>> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
>> Archive: [🔎] CALONj1eefcjep9+he9rmXC9rFdkCH62D4hExTR-2Xs=Gec4t+A@mail.gmail.com">http://lists.debian.org/[🔎] CALONj1eefcjep9+he9rmXC9rFdkCH62D4hExTR-2Xs=Gec4t+A@mail.gmail.com
>>
>
> Anton
>
>
> 2013/9/20 Kevin Bortis <pkgs@bortis.ch>:
>> Package: sponsorship-requests
>> Severity: wishlist
>>
>> Dear mentors,
>>
>> I have updated the packages to adress the last lintian warning about
>> the missing manpage. Musl is a new standard C library, almost written
>> from scratch. It is small like uclibc, but is mostly glibc compatible.
>> For more information: http://www.musl-libc.org/intro.html
>>
>> I would really appreciate if someone could at least hint me, if
>> something with the package is wrong and therefor not qualify for
>> uploading.
>>
>> * Package name : musl
>> Version : 0.9.13
>> Upstream Author : Rich Felker <dalias@aerifal.cx>
>> * URL : http://www.musl-libc.org/
>> * License : MIT
>> Section : libs
>>
>> It builds those binary packages:
>>
>> musl - standard C library
>> musl-dev - standard C library development files
>> musl-tools - standard C library tools
>>
>> Related ITP Bug is:
>>
>> #713072
>>
>> To access further information about this package, please visit the
>> following URL:
>>
>> http://mentors.debian.net/package/musl
>>
>> Alternatively, one can download the package with dget using this command:
>>
>> dget -x http://mentors.debian.net/debian/pool/main/m/musl/musl_0.9.13-2.dsc
>>
>> The git repo for the package is located on github:
>>
>> https://github.com/wermut/musl
>>
>> The repository follows the guideline found under
>> https://wiki.debian.org/PackagingWithGit
>>
>> Thanks in advance
>> Kevin Bortis
>>
>>
>> --
>> To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
>> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
>> Archive: [🔎] CALONj1eefcjep9+he9rmXC9rFdkCH62D4hExTR-2Xs=Gec4t+A@mail.gmail.com">http://lists.debian.org/[🔎] CALONj1eefcjep9+he9rmXC9rFdkCH62D4hExTR-2Xs=Gec4t+A@mail.gmail.com
>>
Reply to: