Bug#662955: RFS: rubyripper/0.6.2-1 [ITP]
On Mon, Aug 19, 2013 at 1:02 AM, Scott Leggett wrote:
> This didn't work for me,
Hmm, it still works for me, are you sure?
> the wiki[0]. Actually, the example has a bug where it looks for two
> adjacent periods in the file name. I note that you were the last editor
> of the page - maybe you could fix the example? (I don't have edit access)
The wiki is open to editing by anyone, you just need to register an account.
Anyway, fixed.
> Is this an issue? I modelled the descriptions on other packages which
> have both a command-line and graphical interface, such as vim/vim-gtk.
Not a huge issue, especially for this package.
>> The SVG source for rubyripper.png is missing from the package.
>
> This is not included upstream either. Does Debian have a policy of not
> accepting rasterised icons?
ftpmasters have a policy of requiring the preferred form for
modification be available and that it be possible to build results
from it on Debian (not necessarily that they be built at build time).
They may or may not notice this issue though.
http://www.debian.org/social_contract#guidelines
http://ftp-master.debian.org/REJECT-FAQ.html
> No, it doesn't look safe to me either (though I hadn't noticed
> previously). See patch 6.
That is a quite ugly fix that may or may not actually fix the issue. I
would suggest that command be an array constructed in the usual way
for ruby and passed to popen, instead of just constructing a string
and then splitting it based on a regex.
> There is no changelog included upstream.
Perhaps they would be willing to include a ChangeLog generated from
the git log or a NEWS file.
> I'll file bugs upstream for these; I'm sure the results would be tragic
> if I tried to fix these using google translate :P
Probably best to avoid that indeed, for various reasons.
> Thanks again for the review. Discovering all these techniques for
> de-linting packages has been very educational!
Glad to be of help.
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: